Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add restartFile command #213

Merged
merged 2 commits into from
Jul 7, 2022
Merged

chore: add restartFile command #213

merged 2 commits into from
Jul 7, 2022

Conversation

gebner
Copy link
Member

@gebner gebner commented Jul 7, 2022

No description provided.

@gebner
Copy link
Member Author

gebner commented Jul 7, 2022

@lovettchris Does the new command name and the explanation in the readme make it clearer what's going on?

@lovettchris
Copy link
Contributor

I see thanks, it is more clear to me now that this restarts the file worker, but I'm not sure it will be more clear to users that know nothing about what a file worker is. I think refreshFileDependencies is more "user centric" in terms of what it is usually used for.

@gebner gebner merged commit 2727147 into master Jul 7, 2022
@gebner
Copy link
Member Author

gebner commented Jul 7, 2022

I'm not sure it will be more clear to users that know nothing about what a file worker is.

Note that the final version of this PR does not contain the words "file worker" anymore. It now only talks about "restarting server for a single file", which is hopefully understandable.

@Julian
Copy link
Contributor

Julian commented Jul 7, 2022

Possibly https://github.com/leanprover/lean4/blob/dd924e5270fbe3b1c0ef739fd0601a7c3fc7745d/src/Lean/Server/README.md#recompilation-of-opened-files needs consideration of which spelling it should mention (right now it mentions refresh file dependencies obviously, but it sounds like restart file may by the preferred spelling now).

Julian added a commit to Julian/lean.nvim that referenced this pull request Jul 7, 2022
@lovettchris
Copy link
Contributor

Nice catch, "refresh file dependencies" is still there in vs code, it is just an alias for "restart file". But I did a bigger search and found "refresh file dependencies" is also mentioned in the quickstart.md, and on line 96 of the vscode-lean4 readme. It was not mentioned in TPIL or fp-lean books. I'll leave it to Gabriel to decide if we want to switch all mentions of "refresh file dependencies" over to the new name...

@gebner gebner deleted the restartfile branch July 20, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants