-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish Course overview #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested
{{#modalbody}} | ||
<!-- {{> quickForm template="bootstrap4-inline" doc=getClickedCourse collection=getCollection schema=courseSchema id="editCourseForm" type="normal"}}--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this please
{{#autoForm template="bootstrap4" doc=getClickedCourse collection=getCollection schema=courseSchema | ||
id="editCourseForm" type="normal"}} | ||
id="editCourseForm" type="normal"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation!
resources/i18n/en.json
Outdated
"title": "Are you sure you want to delete this course? This action cannot be reversed." | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always add a newline at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine
Implement course over view, Closes #21 Closes #20 Closes #19