Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Request for feedback on invite code feature #194
We're Aya and Anke from the Rails Girls Summer of Code and we've been working on the invite code feature for the past few weeks. We wanted to let you know what we've done so far and see if you're happy with the invite code feature as it is. We don't expect you to merge our changes yet because one important feature is still missing (as discussed with Azul).
Here is a list of the changes we made:
Here's a link to our github issues where we track what we're working on:
Please let us know how you like it and if you have any feedback. We still have a few more weeks left to work on the missing features and implement changes.
If that's difficult then we can go through the whole pull request at once.
As I already said in Hamburg, I am very happy with the approach. You are aware of the missing parts yourself. So I have nothing to add in terms of the big picture. This leaves different possibility for using the counter. We can decide upon that later.
Code also looks good to me. I will add a bunch of comments and questions about small things I noticed. They are meant as style suggestions. I'm not sure i follow them myself all the time
As of 3c13802, we saw sign up working with invite codes as well as without. We will apply more testing locally as well as running within the platform tomorrow. Since this is the last week of RGSoC for @ayajaff, we would like to get towards a merge soon given there are no concerns..
added a commit
this pull request
Sep 30, 2015
Sep 30, 2015
1 check passed
I also have been sick lately, so I never got around to reading this PR. I am happy it is merged, although I would like to suggest some changes for the future:
(1) Remove the
The first requires the gem
(2) instead of making InviteCode have a "count" property, how about a "uses_remaining" property? This way, in the future, to support invite codes with multiple uses we just change the initial value to be something greater than 1.
(3) It has been useful for riseup.net to store the invite code that is used by a user, in order to shut down spammers. For privacy reasons, however, LEAP probably doesn't want to force providers to keep this information around permanently. How about a rake task that removes the invite_code from all users that were created longer than 3 months ago?
This was referenced
Oct 1, 2015
@elijh Thank you for your comments!
Re: 1 - Understood about not depending on another gem. One thing I liked about the coupon code gem was the code format, which is easier to read and copy off paper for a human than a non-formatted string. This may be helpful should any providers print out codes and hand them off to new users?
Re: 2 - Yes, we were wondering about the best way to implement this.
I’d say that if we implement this in the near future, is safe enough to assume that only pixelated’s wazokazi provider will have invite codes stored that use the old way
We may want the length configurable in the future, but I think anything longer than 8 characters is unnecessary.
Yes, I think that is better than uses_remaining. I retract what I said.