Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<RecentTransaction /> time is based on side chain block number #172

Open
TimDaub opened this issue Jul 1, 2019 · 0 comments
Open

<RecentTransaction /> time is based on side chain block number #172

TimDaub opened this issue Jul 1, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jul 1, 2019

Scope

  • <RecentTransactions /> is used to display the user's transaction history
  • The block_number a transaction as included in, is used to determine the time when a user made a transaction
  • Currently only side chain transactions are listed in the burner-wallets history even though also mainnet transactions are executable
  • When recording a mainnet transaction with a mainnet block_number, naturally the time estimate is off significantly

Screen Shot 2019-07-01 at 10 45 36

Deliverables

  • Fix time estimates by e.g. not making them dependent on the side chain's block numbers
  • Use a library like moment.js to make proper "time-ago" estimations that are not only in seconds but also in minutes, days and weeks. Make sure to make useful time estimates. E.g. "2.2m ago" is not useful!
  • Display transaction date in History.js too

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

@TimDaub TimDaub added this to the pDAI demo for funding proposal milestone Jul 1, 2019
@TimDaub TimDaub added the bug Something isn't working label Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant