bity.com crypto off-ramping integration

[TimDaub]

Fixes #107

Checkout

Receipt

Order Status

Todos:

• Change all bootstrap usage to rimble-ui
• Make dialogue show button and not prompt when opening Exchange.js
• Make user confirm transaction to bity
• Do proper validation of inputs to avoid user errors
• Remove unnecessarily included contract files again
• Make bity integration i18n ready
• Remove Exchange.js bity integration left-overs
• Cursor on IBAN form resets when changing text in the middle
• Rename Cashout.js to e.g. Bity.js
• Get minimum possible order amount through API
• Store bity order in local storage and allow user to check it's history and status
  • Get correct block timestamp for bity order (it's mainnet not Plasma chain)
• Resolve all TODOs in the code
• Propagate all errors to the user
• Custom <Loader> time? Or Serviceworker that transfers in the background?
• Rebase against current master
• Give annual amount indicator or error (maybe by quering list orders)
• It's not clear whether test bity.com order went through (e.g. bank account name is missing) (it went through)

Problems

I've created issues for problems that I deemed were not solveable in the scope of this PR:

• "Display bity.com annual cashout limit to user": Display bity.com annual cashout limit to user #171
• "Use ethgasstation to predict wait times of Ethereum Mainnet transactions correctly": Use ethgasstation to predict wait times of Ethereum Mainnet transactions correctly #170
• "Allow user to pick their local currency" Allow user to pick their local currency #169
• "<RecentTransaction /> time is based on side chain block number": <RecentTransaction /> time is based on side chain block number #172
• "Use react-i18next instead of i18n": Use react-i18next instead of i18n #173
• "bity.com cashout functionality makes the user wait too long": bity.com cashout functionality makes the user wait too long #183
• "Cashout entire balance through bity.com": Cashout entire balance through bity.com #184 184

[TimDaub]

Please note that this value (15) gets overwritten when componentDidMount is called.

[TimDaub]

Really unhappy with this. But it's currently the way burner-modules are supposed to be written :/

[iamonuwa]

Can we have a quick call about this?

[TimDaub]

@iamonuwa and I had a call. I connected him with @dmihal who's leading the burner-core integration.

[TimDaub]

Still unclear how this can be done with i18n. I'd propose to just ignore it for now...

[TimDaub]

@iamonuwa I did a bit more research and came up with the following issue: #173

[iamonuwa]

i18next is what was used in the initial implementation. That's what the internationalization is running on

[iamonuwa]

I'll take a look at this and see if there is a better solution to it

[art1c0]

Testing off-ramping functionality on mainnet with metamask:

• Try to exit ETH to Fiat ($25)

At the stage or pasting the IBAN there's a warning in the console:

index.js:1437 Warning: A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components
    in input (created by Context.Consumer)
    in StyledComponent (created by Input)
    in Input (at Bity.js:378)...

Then after performing the exchange and metamask confirmation, got this:

Uncaught (in promise) Error: Returned error: Error: Error: [ethjs-rpc] rpc error with payload {"id":5958094193946,"jsonrpc":"2.0","params":["0xf869328477359400809442e17e25f885a0be481867bdc8aab458c442996988012baa5ac39f67d68026a0d9800e725290a7aeae77538a8501de877a8eb4c4c075b6502ba597e30cc6a5bba005a2c1138ebb93fdbc331ee5c73290f83ad5fd9d80a0353ec3a9d7ba12da214c"],"method":"eth_sendRawTransaction"} {"code":-32000,"message":"intrinsic gas too low"}

Burner's interface stalled with this picture:

and there's an error in metamask as well:

Money not lost :)
However expected the transaction to be performed...

Later observed this in the console (maybe related):

Error: Returned values aren't valid, did it run Out of Gas?
    at ABICoder.push../node_modules/web3-eth-abi/src/index.js.ABICoder.decodeParameters (index.js:227)

[iamonuwa]

Testing off-ramping functionality on mainnet with metamask:

• Try to exit ETH to Fiat ($25)

At the stage or pasting the IBAN there's a warning in the console:

index.js:1437 Warning: A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components
    in input (created by Context.Consumer)
    in StyledComponent (created by Input)
    in Input (at Bity.js:378)...

Then after performing the exchange and metamask confirmation, got this:

Uncaught (in promise) Error: Returned error: Error: Error: [ethjs-rpc] rpc error with payload {"id":5958094193946,"jsonrpc":"2.0","params":["0xf869328477359400809442e17e25f885a0be481867bdc8aab458c442996988012baa5ac39f67d68026a0d9800e725290a7aeae77538a8501de877a8eb4c4c075b6502ba597e30cc6a5bba005a2c1138ebb93fdbc331ee5c73290f83ad5fd9d80a0353ec3a9d7ba12da214c"],"method":"eth_sendRawTransaction"} {"code":-32000,"message":"intrinsic gas too low"}

Burner's interface stalled with this picture:

and there's an error in metamask as well:

Money not lost :)
However expected the transaction to be performed...

Later observed this in the console (maybe related):

Error: Returned values aren't valid, did it run Out of Gas?
    at ABICoder.push../node_modules/web3-eth-abi/src/index.js.ABICoder.decodeParameters (index.js:227)

Which network are you testing with?

[art1c0]

mainnet, as i noted in the first sentence :)

[iamonuwa]

Okay,

[art1c0]

Successfully checked on the mainnet with and without metamask: order has been created and processed, view updated with basic details - good work @TimDaub !