Fix buffered seek #118
Merged
Fix buffered seek #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I built this via the ExternalBuilder Jenkins task, compilation errors seem to be due to missing the |
yeswalrus
force-pushed
the
fix-buffered-seek
branch
from
e29d735
to
e04dd3e
Compare
|
try now? |
jdonald
reviewed
Nov 18, 2016
| ASSERT_EQ(0, bs.Read(buf, sizeof(buf))); | ||
|
|
||
| } | ||
|
|
jdonald
reviewed
Nov 18, 2016
| m_readOffset = std::min<std::streamoff>(std::max<std::streamoff>(0, pos), m_lastValidByte); | ||
| m_eof = m_readOffset != pos && m_readOffset > 0; | ||
| return this; | ||
| } |
jdonald
reviewed
Nov 18, 2016
| @@ -42,5 +42,6 @@ namespace leap { | |||
| std::streamsize Read(void* pBuf, std::streamsize ncb) override; | |||
| std::streamsize Skip(std::streamsize ncb) override; | |||
| std::streamsize Length(void) override; | |||
| IInputStream* Seek(std::streampos off) override; | |||
| }; | |||
| } | |||
There was a problem hiding this comment.
Here too although it was this way before your change.
|
We should add an automated check for those formatting issues... |
|
I finally managed to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferedStream did not implement Seek. This function is vital to some downstream functionality.