Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some ts errors #1

Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix: some ts errors #1

merged 1 commit into from
Jul 8, 2022

Conversation

xgqfrms-GitHub
Copy link
Contributor

  1. interface need implements
  2. class need extends & call super()
  3. props need to be initialize

xgqfrms
xgqfrms reviewed Jul 8, 2022
View reviewed changes
index.ts Show resolved Hide resolved
xgqfrms
xgqfrms approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@xgqfrms xgqfrms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good First PR

index.ts Show resolved Hide resolved
@xgqfrms xgqfrms merged commit 283dd42 into learning-js-by-reading-source-codes:main Jul 8, 2022
@xgqfrms xgqfrms added the good first issue Good for newcomers label Jul 8, 2022
@xgqfrms xgqfrms added this to the First PR milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgqfrms xgqfrms xgqfrms approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
First PR
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xgqfrms-GitHub @xgqfrms