Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong password error is unhelpful #2474

Closed
emannes opened this issue Nov 13, 2017 · 1 comment
Closed

Wrong password error is unhelpful #2474

emannes opened this issue Nov 13, 2017 · 1 comment
Assignees
@kkbrum
Milestone
Stable Release 11

Comments

@emannes
Copy link
Contributor

emannes commented Nov 13, 2017

You need to log in before you can access /myesp/login/.

is not a user-friendly error message for when you enter an incorrect password.

image
@kkbrum kkbrum added this to the Splashcon 2019 Hackathon milestone Jan 27, 2019
@kkbrum kkbrum self-assigned this Jan 31, 2019
@willgearty
Copy link
Member

The only time we don't want to show the message is if we clicked the login button ourselves, right? So we would tell the handler if the user initiated the login by adding a little hidden field in the login form. Then, if that hidden field is included in the form data, tell the template not to show that field with a context variable.

@kkbrum kkbrum mentioned this issue Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkbrum kkbrum

Labels
None yet
Projects
None yet
Milestone
Stable Release 11
Development

No branches or pull requests
3 participants
@emannes @willgearty @kkbrum