Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes: Redirect tables cut off when text is too long #3735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes: Redirect tables cut off when text is too long #3735

wants to merge 1 commit into from

Conversation

MysteryManav
Copy link

fixes: #3728

@willgearty willgearty added this to the Stable Release 16 milestone Mar 22, 2024
@willgearty willgearty self-requested a review March 22, 2024 00:09
willgearty
willgearty requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@willgearty willgearty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @MysteryManav! Unfortunately, it looks like this has revealed a different bug with the email redirects table:
image

I think just changing the colspan to 4 here should do the trick:

ESP-Website/esp/templates/program/redirects.html

Line 136 in b404807

<tr><th colspan="6">Email Redirects</th></tr>

@willgearty
Copy link
Member

@MysteryManav do you have any plans to address my review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willgearty willgearty willgearty requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@MysteryManav MysteryManav

Labels
UserInterface
Projects
None yet
Milestone
Stable Release 16
Development

Successfully merging this pull request may close these issues.

Redirect tables cut off when text is too long
2 participants
@MysteryManav @willgearty