Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete login by birthday and school #2127

Merged
merged 1 commit into from Jun 13, 2016
Merged

Conversation

mgersh
Copy link
Contributor

@mgersh mgersh commented Jun 13, 2016

They leak user data. I wrote a more detailed explanation in the changelog.

@benjaminjkraft
Copy link
Contributor

👍 from me, but cc @milescalabresi in case he has thoughts on communicating this to chapters.

@milescalabresi
Copy link
Contributor

Definitely support this change. I'll email chapter reps and check with them in person at the next meeting to make sure it gets communicated to the whole team. Given that it's the summer and that these don't affect much in terms of what admins can do or have to do, I have no big concerns if it doesn't get spread to everyone immediately.

@mgersh
Copy link
Contributor Author

mgersh commented Jun 13, 2016

Note that this won't take effect until next time we do a stable release anyway. (Although we should probably do one soon.)

@benjaminjkraft benjaminjkraft merged commit 510659a into main Jun 13, 2016
@benjaminjkraft benjaminjkraft deleted the delete-alternate-login branch June 13, 2016 04:04
@milescalabresi
Copy link
Contributor

Yeah, I just noticed that. Thanks for pointing that out. Ben, did you want my thoughts on communicating the stable release or communicating this change specifically? In either case, I'm happy to take responsibility for making sure the relevant info gets out to all admins in a reasonable amount of time. Not sure if that was what you meant though.

@mgersh
Copy link
Contributor Author

mgersh commented Jun 13, 2016

I think the specific concern here is users getting confused that the thing they'd used to log in before has disappeared and emailing chapters. Hopefully there won't be too much of that. But just in case, it might be nice to include an explanation and suggested response in the release email when it happens.

@benjaminjkraft
Copy link
Contributor

I meant this change specifically, since it's removing functionality without a replacement, and I think some chapters may actually use this feature, as @mgersh said. I think it'll be okay, just something to keep an eye out for.

@milescalabresi
Copy link
Contributor

Okay, I'll make sure to highlight this specifically slightly before or when the release comes out in that case. Let me know if there are other such things that come up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants