New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded KA Lite version at mac OS X installer. #448

Merged
merged 4 commits into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@mrpau-richard
Member

mrpau-richard commented Apr 26, 2017

Summary

This will fix the hardcoded KA Lite version at the .pkg installer.

Issues addressed

Fixes #426

Show outdated Hide outdated osx/build.sh Outdated
Show outdated Hide outdated osx/build.sh Outdated
@benjaoming

Two comments here, but great to get this fixed and avoid future mixups :)

@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard Apr 26, 2017

Member

@benjaoming Thanks for reviewing this. I've done fixing all your comments.

Member

mrpau-richard commented Apr 26, 2017

@benjaoming Thanks for reviewing this. I've done fixing all your comments.

@mrpau-richard mrpau-richard reopened this Apr 27, 2017

@benjaoming benjaoming merged commit 4f7d79f into learningequality:develop Apr 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrpau-richard mrpau-richard deleted the mrpau:hotfix/426-osx-installer-claims-its-0.16.0-not-0.16.9 branch May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment