-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hardcoded KA Lite version at mac OS X installer. #448
Fix hardcoded KA Lite version at mac OS X installer. #448
Conversation
osx/build.sh
Outdated
echo "Updating KA Lite installer version" | ||
KA_LITE_VERSION="$(kalite --version)" | ||
DOCS_PATH="$SCRIPTPATH/KA-Lite-Packages/docs" | ||
sed -i '' "13s/0.17.0/$KA_LITE_VERSION/g" "$DOCS_PATH/INTRODUCTION.rst.rtfd/TXT.rtf" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
osx/build.sh
Outdated
sed -i '' "13s/0.17.0/$KA_LITE_VERSION/g" "$DOCS_PATH/INTRODUCTION.rst.rtfd/TXT.rtf" | ||
sed -i '' "12s/0.17.0/$KA_LITE_VERSION/g" "$DOCS_PATH/SUMMARY.rtfd/TXT.rtf" | ||
sed -i '' "12s/0.17.0/$KA_LITE_VERSION/g" "$DOCS_PATH/README.rst.rtf" | ||
if [ $? -ne 0 ]; then |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments here, but great to get this fixed and avoid future mixups :)
@benjaoming Thanks for reviewing this. I've done fixing all your comments. |
Summary
Issues addressed
Fixes #426