Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'Filters' pattern page #194

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

jtamiace
Copy link
Member

@jtamiace jtamiace commented Mar 16, 2021

Description

Part of the In docs we trust project

Adds specs and behaviors for these components as they relate to filtering:

  • Dropdown menus
  • Text input dropdowns
  • Text filters
  • Checkbox lists

Reviewer guidance

This new page documents specs for our current use of filters. Looking for feedback on anything that's missing, inaccurate, or under-specced.

Comments

Later I'll add two follow up issues that I couldn't document for now because of inconsistencies & undesirable behaviors, and the fact that library implementation would need to happen first or in tandem:

  • Multi-select dropdown filters: we need a better representation of multiple selections at one time and how long text is handled
  • This new page states that when there are '0 results' for a filter in a dropdown, we should hide that option from the dropdown. In the future, we should also communicate the number of missing options in a filter dropdown menu and why they are hidden via a tooltip.

Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

@indirectlylit indirectlylit merged commit 4ad2e07 into learningequality:v0.2.x Mar 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants