Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icons for Kolibri 0.15 #270

Merged
merged 11 commits into from
Oct 28, 2021

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Oct 26, 2021

Description

  • add new Material and custom icons
  • allow building just the custom icons
  • fix extraction pattern

Issue addressed

fixes #260

Before/after screenshots

See deploy preview for full view

before after
image image

Steps to test

Compare with reference:

https://docs.google.com/document/d/1ahajDGXWR-Pym8ujBSXbXnw_7BOnYsB0O9TubabQRPg/edit

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change has been added to the changelog

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Post-merge updates and tracking

  • Learning Platform update PR is submitted
  • Learning Platform update PR is merged
  • Studio update PR is submitted
  • Studio update PR is merged
  • Data Portal update PR is submitted
  • Data Portal update PR is merged

Comments

@jtamiace
Copy link
Contributor

Screen Shot 2021-10-26 at 12 41 02 PM

Screen Shot 2021-10-26 at 12 41 08 PM

Only missing icon seems to be 'skills' which got grouped with 'math'.
All the other icons & aliases look good!

@indirectlylit
Copy link
Contributor Author

indirectlylit commented Oct 28, 2021

great, thanks.

Turned out that history was already a defined name so used a new section and convention for "Resource categories":


image


image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KDS icon updates for Kolibri 0.15
2 participants