Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update KDS to v1.1.0, introducing new icons #8552

Merged

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Oct 28, 2021

Summary

Updates KDS to v1.1.0, which primarily makes the new icons available from learningequality/kolibri-design-system#270

Includes new resource category and other 0.15-related icons. For example:

<KIcon icon="socialScienceResource" />
<KIcon icon="artsResource" />
<KIcon icon="publicHealthResource" />
<KIcon icon="mediaLiteracyResource" />
<KIcon icon="numeracyResource" />
<KIcon icon="digitalLiteracyResource" />
<KIcon icon="guidesResource" />
<KIcon icon="lessonPlansResource" />
<KIcon icon="mathResource" />
<KIcon icon="scienceResource" />
<KIcon icon="readingWritingResource" />
<KIcon icon="historyResource" />
<KIcon icon="computerScienceResource" />
<KIcon icon="entrepreneurshipResource" />
<KIcon icon="financialLiteracyResource" />
<KIcon icon="currentEventsResource" />
<KIcon icon="environmentResource" />
<KIcon icon="diversityResource" />
<KIcon icon="mentalHealthResource" />
<KIcon icon="literacyResource" />
<KIcon icon="logicCriticalThinkingResource" />
<KIcon icon="learningSkillsResource" />
<KIcon icon="skillsResource" />

image

Reviewer guidance

Are you able to use the new icons from https://design-system.learningequality.org/icons/#icons


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit indirectlylit changed the title update KDS to v1.1.0 update KDS to v1.1.0, introducing new icons Oct 28, 2021
@indirectlylit indirectlylit added this to the 0.15.0 milestone Oct 28, 2021
@indirectlylit indirectlylit added the TODO: needs review Waiting for review label Oct 28, 2021
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- tested locally and the new icons are working!

@marcellamaki marcellamaki merged commit 48075ed into learningequality:release-v0.15.x Oct 28, 2021
@indirectlylit indirectlylit deleted the update-kds branch November 3, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants