Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second call to getline #190

Merged
merged 1 commit into from
May 26, 2021
Merged

Remove second call to getline #190

merged 1 commit into from
May 26, 2021

Conversation

jonboiser
Copy link
Contributor

Testing learningequality/kolibri#8083, it seems like calling getline twice ends up discarding the first two lines, so that when we read the line, we're actually getting the third line. So this just removes the second call.

@jonboiser jonboiser merged commit 0d0de18 into develop May 26, 2021
@jonboiser jonboiser deleted the jonboiser-patch-1 branch May 26, 2021 23:47
@radinamatic
Copy link
Member

radinamatic commented May 27, 2021

We seem to be closer with the build from this PR, but not completely there yet:

  • After the installation, Kolibri.exe (taskbar launcher) still announces that the server will be running on the port 4xxxx, but the browser opens the correct port 8080.
  • However, if the browser is closed, and reopened with the Load in a browser option from the launcher menu, browser loads the page at the port 4xxxx 😕
  • Similarly, if the server is stopped and restarted from the desktop shortcut, or the system is restarted, browser will still load the page on the port 4xxxx.

@radinamatic
Copy link
Member

Tested on Windows 7, but it will almost certainly be the same on Win 10.

win7-start

@micahscopes
Copy link
Contributor

That 49189 still appears to be line #3. I wonder if there's some kind of build cache issue that's really the cause of our woes here?

@rtibbles
Copy link
Member

rtibbles commented Jul 9, 2021

Running a minimal version of the CPP logic in Windows against a PID file suggests to me that our work here has not made it downstream. @micahscopes's edit should have correctly returned the second line, and @jonboiser's edit would be returning the first line.

@rtibbles
Copy link
Member

rtibbles commented Jul 9, 2021

That said - looking at the build job on buildkite, it does seem to be fetching the proper commit :/

@rtibbles
Copy link
Member

rtibbles commented Jul 9, 2021

The only thing I can think of here is that somehow the updating of the PID file by Kolibri is causing inconsistent reads by the CPP application. Going to do some more testing locally to see if repeated reads change while Kolibri is booting up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants