Fix Windows installer to correctly detect running Kolibri

[micahscopes]

Summary

This integrates a fix for the Windows installer, so that the installer gets the correct port information from server.pid when putting together a running Kolibri instance's base URL.

References

• Only use second line of server.pid for port info kolibri-installer-windows#188

Reviewer guidance

• @radinamatic knows how to test this!

Testing checklist

• Contributor has fully tested the PR manually

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[radinamatic]

We don't seem to be there yet 😕

On Windows 7, Kolibri.exe launcher still picks up the 4xxxx port by default, displays it in the system notification, and opens the browser with it.

I will re-test on Windows 10 to confirm, but doubt that anything will change.

[radinamatic]

Confirmed as still extant on Windows 10 too:

[jonboiser]

@radinamatic @micahscopes Can you try to find the actual server.pid file on the VM? Looking at the code here, does the fact that it is looking for a specific port mean that

httpLink = joinChr("http://127.0.0.1:", line.c_str());

Evaluates to something? Otherwise wouldn't it just be httpLink = http://127.01.0.1<some inappropriate data>?

https://github.com/learningequality/kolibri-installer-windows/blob/develop/src/gui-source/Kolibri/Kolibri.cpp#L81

[radinamatic]

@jonboiser That's the first thing both @rtibbles and @micahscopes asked for, but PID files were apparently OK 😕

pids.zip

[rtibbles]

The most confusing thing here is that it is picking up a discrete line in the PID file, it's just picking up the third line instead of the second.

[rtibbles]

Additional testing of a stripped down version of the PID reading code running against a Kolibri server shows very consistent output - always picking up the correct port, and returning nothing when the port is not available to be read.

Really not sure what is causing this to go awry in production.

[radinamatic]

Shipit! 💯 🎉

Win 7	Win 10

[radinamatic]

Fixed, thank you @rtibbles! 👍🏽

[rtibbles]

For posterity - @micahscopes had made the correct fix, but we needed to rebuild the exe and commit it to the repo for the fix to take effect.