Merge pull request #8580 from nucleogenesis/metadata-panel-channels-fix

sidepanel was hidden by mistake on channels, fixed some errors in BrowseResourceMetadata
learningequality · Nov 3, 2021 · e527889 · e527889
2 parents d0eb25d + 36a3265
commit e527889
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/kolibri/plugins/learn/assets/src/views/BrowseResourceMetadata.vue b/kolibri/plugins/learn/assets/src/views/BrowseResourceMetadata.vue
@@ -180,15 +180,16 @@
     <div v-if="showLocationsInChannel && locationsInChannel" class="section" data-test="locations">
       <div class="label">
         {{
-          metadataStrings.$tr('locationsInChannel', { 'channelname': content.ancestors[0].title })
+          metadataStrings
+            .$tr('locationsInChannel', { 'channelname': (content.ancestors[0] || {}).title })
         }}:
       </div>
       <div v-for="location in locationsInChannel" :key="location.id">
         <div>
           <KRouterLink
-            :to="genContentLink(location.ancestors.splice(-1)[0].id, false)"
+            :to="genContentLink((location.ancestors.splice(-1)[0] || {}).id, false)"
           >
-            {{ location.ancestors.splice(-1)[0].title }}
+            {{ (location.ancestors.splice(-1)[0] || {}).title }}
           </KRouterLink>
         </div>
       </div>

diff --git a/kolibri/plugins/learn/assets/src/views/TopicsPage.vue b/kolibri/plugins/learn/assets/src/views/TopicsPage.vue
@@ -629,11 +629,6 @@
     max-width: 920px;
   }
 
-  /deep/.side-panel {
-    position: relative;
-    bottom: 0;
-  }
-
   /deep/.card-thumbnail-wrapper {
     max-width: 100%;
     height: 110px;