sidepanel was hidden by mistake on channels, fixed some errors in BrowseResourceMetadata #8580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Takes care of a couple issues around showing metadata side panel with BrowseResourceMetadata.
TopicsPage
the side panel was being coerced with some /deep/ css to be off screen so I removed that.undefined
w/ the ancestors splicing business in showing channel locations were showing up and I made sure it always got an object instead of undefined.References
Fixes do not reference an issue (that I know of anyway).
Reviewer guidance
Go to a channel (with the black top bar) and try to open the side panel. Do you see everything where it ought to be?
Check the console, any errors about
title
or similar not being defined? Any errors at all pointing toBrowseResourceMetadata
directly?Testing checklist
PR process
Reviewer checklist
yarn
andpip
)