-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve loading UX on some places in Coach #11201
Improve loading UX on some places in Coach #11201
Conversation
Build Artifacts
|
so that they can be commited together with their sizes. Fixes learningequality#10797
3e73590
to
842480e
Compare
- Resolves seemingly unresponsive toggle switch on slow networks and prevents from repeated clicks. - Includes related re-ordering of async events to achieve consistent UX.
842480e
to
eca698d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I really love seeing the show
being used in a real use case. It looks like a real pleasure to use and I hope I get a chance to integrate it into other places where our loaders are used!
KDS reference updated |
Summary
Last item affects UX on faster networks as well. To prevent from jarring UX, a loader will be displayed for at least 2 seconds even when all requests have finished. Hopefully this helps overall to make UX feel trustworthy taking into account that toggling a lesson visibility is an important operation that would ideally give coaches some feedback.
References
Fixes #10797
Reviewer guidance
Toggle lessons visibility in Plan > Coach on fast network as well as slow network (you can use network throttling in browser dev tools)
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)