Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[re-open] Fix #11881 Side navigation scrolling #11992

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

poju3185
Copy link
Contributor

Summary

Fixes #11881
When the side nav was scrolled to its top or bottom limit, further scrolling attempts would unexpectedly propagate to the main content area, causing it to scroll instead. To resolve this issue, I've added the CSS property overscroll-behavior: contain; to the .side-nav-scrollable-area class, containing the scroll within the side nav and preventing it from affecting the main content area.

References

https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior

Reviewer guidance

  1. Run the Kolibri Mac app on the browser
  2. Open the main side navigation
  3. Scroll, and observe the main page content does not also scrolling

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md
before.mov
after.mov

Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the target branch. The code changes look good to me. This pr can be approved and merged after a QA review!

Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @poju3185 - I confirm that this is fixed now!

@LianaHarris360 LianaHarris360 merged commit 2773b08 into learningequality:release-v0.16.x Mar 22, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac App: Opening the side navigation and scrolling activates scrolling for main page as well
3 participants