-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11881 Side navigation scrolling #11986
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this; the change looks good! Could you please retarget this pull request to the release-v0.16.x
branch instead of develop
so that this change can be included in the next planned patch?
@LianaHarris360, sorry I have to create another PR(#11992). This one was automatically closed when I was trying to retarget the release branch. |
Summary
Fixes #11881
When the side nav was scrolled to its top or bottom limit, further scrolling attempts would unexpectedly propagate to the main content area, causing it to scroll instead. To resolve this issue, I've added the CSS property
overscroll-behavior-y: contain;
to the.side-nav-scrollable-area
class, containing the scroll within the side nav and preventing it from affecting the main content area.References
https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)before.mov
after.mov