Corrected the focus order to match elements order AND adjusted CSS #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 74.13% (diff: 100%)@@ master #480 diff @@
==========================================
Files 115 115
Lines 3832 3832
Methods 143 143
Messages 0 0
Branches 446 446
==========================================
Hits 2841 2841
Misses 947 947
Partials 44 44
|
|
@rayykim - I'm reviewing this work now. Wanted to check if it relates to anything you're working on? |
|
@radinamatic oooh i like the video demo! very informative |
| @@ -220,6 +221,7 @@ | |||
| &:focus | |||
| outline: none | |||
| border-color: transparent | |||
| border-bottom: 2px solid $core-action-normal | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
updates to user management page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#467 was reverted because I didn't bother to check all resolutions... 😞
Annoying thing is that Firefox and Chrome render responsive widths differently, so the first commit here looked fine in FF, but not in Chrome for iPad width:
Firefox
Chrome
Few more retouches rendered OK in Chrome too, but now it leaves a few unused pixels in FF:
Firefox
Chrome
@indirectlylit @DXCanas @rayykim