Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of "exit search" button in lesson search #4929

Merged
merged 4 commits into from
Feb 6, 2019

Conversation

jonboiser
Copy link
Contributor

Summary

Fixes #4918

Reviewer guidance

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Gherkin stories have been updated
  • Unit tests have been updated

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.rst

@rtibbles rtibbles added this to the 0.12.0 milestone Feb 5, 2019
@rtibbles rtibbles changed the base branch from develop to release-v0.12.x February 5, 2019 20:22
@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #4929 into release-v0.12.x will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-v0.12.x    #4929      +/-   ##
===================================================
+ Coverage             49.9%   49.91%   +0.01%     
===================================================
  Files                  882      882              
  Lines                27460    27495      +35     
  Branches              3634     3645      +11     
===================================================
+ Hits                 13703    13725      +22     
- Misses               12960    12973      +13     
  Partials               797      797
Impacted Files Coverage Δ
...ach/assets/src/modules/coachNotifications/index.js 0% <ø> (ø) ⬆️
...h/assets/src/modules/coachNotifications/getters.js 3.12% <ø> (+0.09%) ⬆️
...c/views/plan/LessonResourceSelectionPage/index.vue 0% <0%> (ø) ⬆️
kolibri/utils/conf.py 80.7% <0%> (-3.51%) ⬇️
kolibri/utils/cli.py 67.25% <0%> (-2.47%) ⬇️
kolibri/plugins/coach/class_summary_api.py 56.09% <0%> (ø) ⬆️
kolibri/plugins/coach/api_urls.py 100% <0%> (ø) ⬆️
kolibri/core/logger/api.py 84.74% <0%> (+0.81%) ⬆️
kolibri/plugins/coach/api.py 49.1% <0%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464ec26...930b978. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #4929 into release-v0.12.x will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-v0.12.x   #4929      +/-   ##
==================================================
- Coverage             49.9%   49.9%   -0.01%     
==================================================
  Files                  882     882              
  Lines                27460   27440      -20     
  Branches              3634    3633       -1     
==================================================
- Hits                 13704   13694      -10     
+ Misses               12959   12949      -10     
  Partials               797     797
Impacted Files Coverage Δ
...s/coach/assets/src/views/home/HomeActivityPage.vue 0% <ø> (ø) ⬆️
...ach/assets/src/modules/coachNotifications/index.js 0% <ø> (ø) ⬆️
...h/assets/src/modules/coachNotifications/getters.js 3.12% <ø> (+0.09%) ⬆️
...plugins/coach/assets/src/modules/groups/actions.js 0% <ø> (ø) ⬆️
...c/views/plan/LessonResourceSelectionPage/index.vue 0% <0%> (ø) ⬆️
kolibri/utils/conf.py 80.7% <0%> (-3.51%) ⬇️
kolibri/utils/cli.py 67.25% <0%> (-2.82%) ⬇️
kolibri/plugins/coach/class_summary_api.py 56.09% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 464ec26...d132dd8. Read the comment docs.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue, everything working as expected.

@rtibbles rtibbles merged commit a407195 into learningequality:release-v0.12.x Feb 6, 2019
@rtibbles rtibbles mentioned this pull request Feb 7, 2019
9 tasks
@jonboiser jonboiser deleted the exit-search branch February 11, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants