-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version 1 exams missing counterInExercise field #5431
Fix version 1 exams missing counterInExercise field #5431
Conversation
Codecov Report
|
3ebc876
to
ed64854
Compare
my guess/hope is that this will also address #5425 |
# Conflicts: # kolibri/core/exams/serializers.py
# Conflicts: # kolibri/core/exams/serializers.py
d9a33e6
to
d2d02de
Compare
I tested the latest commits and they resolved the issues we discussed on Slack. When there are no There appears to be a failing test (which I get locally as well running |
54ef53c
to
9bf0ae0
Compare
9bf0ae0
to
d6ffb7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonboiser Looks great!
Summary
Reviewer guidance
using the current 0.12 branch, which should create exams that are V1. Edit the Exam models in the shell, or via a REST tool to create Exams whosequestion_sources
items are missing thecounterInExercise
field and also have adata_model_version
field equal 0. Confirm that the problem in 'NaN' in titles of difficult questions #5427 occursReferences
Fixes #5427
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)