Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change assignable coach landing page after login #7620

Merged

Conversation

alexMet
Copy link
Contributor

@alexMet alexMet commented Oct 26, 2020

Summary

Change the assignable coach landing page after logging in from learn to coach.

simplescreenrecorder

References

#7611


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Contributor

@jonboiser jonboiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonboiser
Copy link
Contributor

Looks good. I just noticed there are no tests for coach redirection here

def test_redirect_root_to_learn_if_logged_in(self):

So I'll add in new test cases for the Facility coach and Assignable coach

@jonboiser jonboiser merged commit 7dbd19f into learningequality:release-v0.14.x Oct 27, 2020
@alexMet alexMet deleted the coach-login-landing-page branch November 5, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important user-facing changes
Projects
None yet
2 participants