Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for root_redirect hook when logging in as coach #7621

Merged

Conversation

jonboiser
Copy link
Contributor

Summary

Following up on #7620 (comment), this

  1. adds two tests to verify that facility and class coaches get redirected to the coach plugin when they login.
  2. refactors the TestCase class and renames the individual test cases

Reviewer guidance

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jonboiser jonboiser added the TODO: needs review Waiting for review label Oct 27, 2020
@jonboiser jonboiser added this to the 0.14.4 milestone Oct 27, 2020
@jonboiser jonboiser changed the title Add tests for root_redirect hook when logging as coach Add tests for root_redirect hook when logging in as coach Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #7621 into release-v0.14.x will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
kolibri/core/tasks/utils.py 87.03% <0.00%> (-5.56%) ⬇️

@jonboiser jonboiser merged commit 2fe2213 into learningequality:release-v0.14.x Oct 27, 2020
@jonboiser jonboiser deleted the redirection-tests branch October 27, 2020 23:54
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant