When toggling Demo Banner, do not send focus to a new location outside of the sign-in page forms #7932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonboiser
reviewed
Mar 29, 2021
| methods: { | ||
| toggleBanner() { | ||
| this.bannerClosed = !this.bannerClosed; | ||
| this.previouslyFocusedElement.focus(); |
There was a problem hiding this comment.
Put a guard here, since it's possible that this.previouslyFocusedElement is undefined.
jonboiser
reviewed
Mar 29, 2021
| }, | ||
| focusChange(e) { | ||
| // We need the element prior to the close button | ||
| if (this.$refs.close_button && e.target != this.$refs.close_button.$el) { |
There was a problem hiding this comment.
This extra check for $refs.close_button can make this feature a little confusing. For example, if I do this:
- At Sign-In screen, click "Close" on demo bar right away.
- Use my keyboard to focus on the "Create Account" button
- Press "More info" on demo bar
- Then focus returns to the username bar.
Do you think you can update this to always have this behavior:
Given The demo banner is in closed state
When I focus on an element `$el` on the sign-in page
And I re-open the demo banner
And I re-close the demo banner
Then focus is returned to `$el`.
Here's a video of the scenario above.
There was a problem hiding this comment.
okay I understood I will do it.
… info banner button is clicked and transfer focus to that element once the header is dismissed.
apurva-modi
force-pushed
the
7661-Demo-site-header-focus-issue
branch
from
a8c1e73
to
dfd7a9b
Compare
jonboiser
changed the title
jonboiser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recorded the previous element that holds focus before the close button is clicked and transfer focus to that element once the header is dismissed
…
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarnandpip)