Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #7932 and remove admin credentials from demo banner #7973

Merged

Conversation

jonboiser
Copy link
Contributor

Summary

  1. Cherry-picks When toggling Demo Banner, do not send focus to a new location outside of the sign-in page forms #7932 to 0.14.7
  2. Removes admin credentials from the demo banner copy

apurva-modi and others added 2 commits April 7, 2021 14:21
… info banner button is clicked and transfer focus to that element once the header is dismissed.
@jonboiser jonboiser added this to the 0.14.7 milestone Apr 7, 2021
@jonboiser jonboiser merged commit f842833 into learningequality:release-v0.14.x Apr 8, 2021
@jonboiser jonboiser deleted the update-demo-banner branch April 8, 2021 23:24
@pcenov
Copy link
Member

pcenov commented Apr 9, 2021

Tested and verified at https://kolibri-beta.learningequality.org/en/user/#/signin - the admin credentials are removed from the demo banner.

@pcenov
Copy link
Member

pcenov commented Apr 9, 2021

@jonboiser I just noticed that now that the admin credentials have been removed we should probably change the text above the credentials as well which is incorrect because it says: "Explore any of the three primary user types:"
2021-04-09_17-37-20
@radinamatic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants