Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDP-friendly kolibri-tools version #8085

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented May 13, 2021

Ran yarn publish-packages on develop - successfully bumped all package versions and published them to npm.

Also made @rtibbles owner https://www.npmjs.com/package/browserslist-config-kolibri/access

Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a small bug cause by one comma

@nucleogenesis
Copy link
Member Author

@jredrejo apologies I missed your review on this - just pushed a fix.

packages/publish.js Outdated Show resolved Hide resolved
@nucleogenesis
Copy link
Member Author

@rtibbles @jredrejo I thought I'd clean this up really quickly and ran the packages/publish script - which updated the package.json files - but when I go to NPM I don't see the versions.

So I ran it again and get this now:

error Couldn't publish package: "https://registry.yarnpkg.com/kolibri-tools: You cannot publish over the previously published versions: 0.14.8-dev.1."

I'm clearly missing something here... https://www.npmjs.com/package/kolibri-tools

packages/publish.js Outdated Show resolved Hide resolved
@rtibbles
Copy link
Member

I'm clearly missing something here... https://www.npmjs.com/package/kolibri-tools

0.14.8-dev.1 is there as next. Because of the extant edits to the publishing command though, there is no updated version of the eslint-plugin-kolibri package, nor the kolibri package.

This PR also needs to be rebased as it has multiple merge conflicts.

@nucleogenesis
Copy link
Member Author

@rtibbles how weird - npm really showed only 0.14.7 as next until I came back to it this morning and refreshed.

I cannot find or un-privatize that browserslist package on npm. If you can make that public I will re-run the command on the latest develop branch and force push on this branch.

@rtibbles
Copy link
Member

rtibbles commented Sep 1, 2021

The browserlist-config-kolibri package has not been published to npm yet - we just need to remove this flag from the package.json https://github.com/learningequality/kolibri/blob/release-v0.15.x/packages/browserslist-config-kolibri/package.json#L9 to unflag it as private.

@nucleogenesis
Copy link
Member Author

So - it looks like kolibri-components is a requirement for the version of kolibri-tools that KDS points to.

I think we'll just need to update the commit we're pointing to for KDS in kolibri/core/package.json once learningequality/kolibri-design-system#258 is merged.

@nucleogenesis
Copy link
Member Author

There is an additional issue that kolibri-tools cli expects there to be a ./setup.cfg file in any implementing repository.

This commit introduces an issue now where the cli tools are unusable in kolibri-design-system when using the latest kolibri-tools that was published here.

I can create a separate issue for that - which will block the completion of this one as we'll want to rebase this onto those changes, publish again, then merge along with KDS#258

@rtibbles
Copy link
Member

rtibbles commented Sep 1, 2021

This commit introduces an issue now where the cli tools are unusable in kolibri-design-system when using the latest kolibri-tools that was published here.

Ah, whoops - should have made this optional.

@indirectlylit indirectlylit mentioned this pull request Sep 23, 2021
9 tasks
@indirectlylit
Copy link
Contributor

migrated work to #8459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants