-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDP-friendly kolibri-tools version #8085
KDP-friendly kolibri-tools version #8085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a small bug cause by one comma
@jredrejo apologies I missed your review on this - just pushed a fix. |
@rtibbles @jredrejo I thought I'd clean this up really quickly and ran the So I ran it again and get this now:
I'm clearly missing something here... https://www.npmjs.com/package/kolibri-tools |
0.14.8-dev.1 is there as This PR also needs to be rebased as it has multiple merge conflicts. |
@rtibbles how weird - npm really showed only 0.14.7 as I cannot find or un-privatize that browserslist package on npm. If you can make that public I will re-run the command on the latest |
The browserlist-config-kolibri package has not been published to npm yet - we just need to remove this flag from the package.json https://github.com/learningequality/kolibri/blob/release-v0.15.x/packages/browserslist-config-kolibri/package.json#L9 to unflag it as private. |
3445916
to
4aeaf81
Compare
So - it looks like I think we'll just need to update the commit we're pointing to for KDS in kolibri/core/package.json once learningequality/kolibri-design-system#258 is merged. |
There is an additional issue that This commit introduces an issue now where the cli tools are unusable in I can create a separate issue for that - which will block the completion of this one as we'll want to rebase this onto those changes, publish again, then merge along with KDS#258 |
Ah, whoops - should have made this optional. |
migrated work to #8459 |
Ran
yarn publish-packages
ondevelop
- successfully bumped all package versions and published them to npm.Also made @rtibbles owner https://www.npmjs.com/package/browserslist-config-kolibri/access