Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades KDS and dependencies #8459

Merged
merged 9 commits into from Sep 24, 2021

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Sep 23, 2021

Summary

  • Upgrade vue from 2.6.11 -> 2.6.14 in line with KDS
  • Remove counterproductive kolibri-tools references which were pinning to old versions rather than using yarn workspace symlinks
  • Allow browserlist-config-kolibri to be published
  • Upgrade private packages to 0.15.0-dev.4 (see follow-up issue updates to naming and versioning of internal packages and tools #8454)
  • Upgrade KDS to v1.0.0

References

Reviewer guidance

Sanity-check to make sure things run as well as they did prior to this commit


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit indirectlylit changed the title Upgrades 3 Upgrades KDS and dependencies Sep 23, 2021
@indirectlylit indirectlylit added this to the 0.15.0 milestone Sep 23, 2021
@indirectlylit indirectlylit added the TODO: needs review Waiting for review label Sep 23, 2021
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should clean up the code that does this version setting logic as well as the versions themselves:
https://github.com/learningequality/kolibri/blob/release-v0.15.x/packages/publish.js#L57

Aside from this, the asset has built fine and runs as expected.

packages/kolibri-tools/package.json Show resolved Hide resolved
@indirectlylit
Copy link
Contributor Author

updated with cleanup to publish.js

@rtibbles rtibbles merged commit 7e97b86 into learningequality:develop Sep 24, 2021
@indirectlylit indirectlylit deleted the upgrades-3 branch September 28, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants