New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades KDS and dependencies #8459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should clean up the code that does this version setting logic as well as the versions themselves:
https://github.com/learningequality/kolibri/blob/release-v0.15.x/packages/publish.js#L57
Aside from this, the asset has built fine and runs as expected.
updated with cleanup to publish.js |
Summary
kolibri-tools
references which were pinning to old versions rather than using yarn workspace symlinksReferences
Reviewer guidance
Sanity-check to make sure things run as well as they did prior to this commit
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)