Additional strings

[marcellamaki]

Adds missing strings, fixes typos, removes/streamlines duplicates.

[radinamatic]

Can you change the message for noUsersExistLabel into 'There are no users in this facility'?

[radinamatic]

This can also be reused in the MarkAsCompleteModal.

Also, the Resource completed string appears in both MarkAsCompleteModal and the CompletionModal. Can you move it in the commonLearn strings and reuse?

[radinamatic]

Can you change the message in the markResourceAsCompleteConfirmation to be 'Are you sure you want to mark this resource as completed?' (completed instead of finished).

[radinamatic]

And as mentioned in Slack, since this value needs to be pluralized, change the message for results into:

message: '{results, number, integer} {results, plural, one {result} other {results}}',

[radinamatic]

Please change the value for the browseChannel to be 'Browse channels' (sentence case).

[radinamatic]

We have LearningActivities defined in both commonCore and commonLearn strings 🤔

I see those from commonCore used only in the LearningActivityLabel component (which is also in the Learn plugin 🙂), so maybe it makes sense to apply those from the commonLearn, and delete the definitions in the commonCore?

[rtibbles]

I see those from commonCore used only in the LearningActivityLabel component (which is also in the Learn plugin slightly_smiling_face), so maybe it makes sense to apply those from the commonLearn, and delete the definitions in the commonCore?

Given that we will be almost certainly using this metadata in Coach and Device at some point in the future, it makes the most sense to move all these strings into commonCore.

[marcellamaki]

Okay - since the version in learn is more complete, I will copy that over to core to retain the context, but delete from learn.

[radinamatic]

Delete the line 474 from the commonCore strings, as that category (Logic and critical thinking) is duplicated, and defined also in the line 497.

[radinamatic]

Still pending to refactor the Explore resources to... strings.

If I remember correctly, we decided to concatenate like so: Explore resources - '{ category }' cc @rtibbles

[radinamatic]

Can you change the message in the examReportTitle to be 'Report for { examTitle }' (for clarity)?

[marcellamaki]

Still pending to refactor the Explore resources to... strings.

If I remember correctly, we decided to concatenate like so: Explore resources - '{ category }' cc @rtibbles

yes - this is in the code I have not pushed yet. Trying to consolidate so you are not re-reviewing too many times!

[radinamatic]

This Accessibility string can be reused from the commonCore strings.

And while you're at it, I also see the string Language in the following components:

• SelectGroup
• SidePanelResourceMetadata
• FilteredChannelListContainer
• MediaPlayerIndex

While Level is repeated in 2 components:

• SelectGroup
• SidePanelResourceMetadata

High time to put both into commonCore 😉

[radinamatic]

Final push looking good! 👏🏽 💪🏽