New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync operation support to Kolibri plugins with migration for exam logs #8527
Add sync operation support to Kolibri plugins with migration for exam logs #8527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - one comment on a comment, any blockers from your side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through looks good, one update needed for the notification generation.
ExamLog | ||
) | ||
logger.info("Migrating {} ExamLogs records".format(len(exam_logs_ids))) | ||
migrate_from_exam_logs(ExamLog.objects.filter(id__in=exam_logs_ids)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realizing that this won't handle updated ExamAttemptLogs that are associated with an otherwise unchanged ExamLog. Let's file this as a follow up issue that I can tackle.
@bjester today I tested the Buildkite builds for this one and found some quiz related syncing issues. I was wondering whether you are aware of these:
|
Summary
References
Resolves #8481
Resolves #8487
Reviewer guidance
Note: notification generation post-sync hasn't yet been updated for new log structure
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)