New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve missing kind preventing successful sync of quiz logs and quieter sync logging #8592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good - seems like Django is not entirely convinced that the migration for the logger app exists? Possible it's some weird Py2/3 discrepancy, so maybe try rerunning makemigrations with Python 2 and see if anything different pops up?
@rtibbles I didn't think it needed a migration, and thought I would see a warning running tests if it did, so I didn't initially commit a migration 👍 |
Ah - gotcha! Yeah, Django likes to add a migration for any model change, regardless of whether it actually affects the DB or not. |
Hi @bjester, while testing this I noticed that only the first part of my comment is fixed with this PR namely a Coach is now able to see the scores of a learner and any questions answered. |
@bjester - weird that interaction history is not an array, but perhaps we can coerce that in the API request, in the case that it is falsy for some reason? |
Thanks for testing @pcenov! What instance was the quiz completed on? And what instance did you check the result as the Coach? I should have noted in the prior PR that we didn't make the quiz results compatible with older versions, so if the quiz was completed on 0.15 then I wouldn't expect it to show up correctly in 0.14, but the other way around should work appropriately |
The quiz was completed on the 14.7 instance which was then imported in 0.15 where I was subsequently checking the results. So yeah, it seems that there is an issue indeed. |
Okay yes that sounds like a bug. I will investigate. |
Summary
kind
forContentSessionLog
References
Addresses @pcenov's comment
Resolves #8394
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)