Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade issue #8954

Merged
merged 3 commits into from Dec 20, 2021

Conversation

rtibbles
Copy link
Member

Summary

  • Do all plugin changes before checking options
  • Prevent logging from accessing the options and hence initializing the registry while the plugin configuration is still being cleaned up

References

Fixes unresolved issue first noted here: #8895 (comment)

Reviewer guidance

Do the upgrade from 0.14.7 to 0.15.0 does everything work as expected? Specifically, can you see Perseus exercises anywhere in the UI?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Dec 18, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Dec 18, 2021
@radinamatic
Copy link
Member

Alleluia!!! Coaches and learners are back in business of checking reports when they upgrade to Windows 0.15 🎉 🎉 🎉 🎉

Perseus exercises are good all over!

windows-install-4-YEYYYYYY

@radinamatic
Copy link
Member

@pcenov Could you do the sanity check for upgrade on Ubuntu, before we approve and merge? Thank you!

@pcenov
Copy link
Member

pcenov commented Dec 20, 2021

@radinamatic The upgrade from 0.14.7 to 0.15.0 on Ubuntu passed correctly and as expected. Also no issues with the Perseus exercises.

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're back in upgrade business, merge away! 💯

@marcellamaki marcellamaki merged commit ded2264 into learningequality:release-v0.15.x Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants