Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping text on "Import from other channels" dropdown #4166

Closed
marcellamaki opened this issue Jun 22, 2023 · 6 comments · Fixed by #4186
Closed

Overlapping text on "Import from other channels" dropdown #4166

marcellamaki opened this issue Jun 22, 2023 · 6 comments · Fixed by #4186
Assignees
Labels
bug P1 - important Priority: High impact on UX

Comments

@marcellamaki
Copy link
Member

Observed behavior

Reported by Lauren in the 2023-21-06 bug hunt

Screenshot 2023-06-21 at 12 24 58 PM Screenshot 2023-06-21 at 12 23 28 PM

Expected behavior

Text should either be truncated or properly spaced so that it does not overlap

User-facing consequences

Readability issues

Usage Details

hotfixes bug hunt, 2023-21-06

@marcellamaki marcellamaki added P1 - important Priority: High impact on UX bug labels Jun 22, 2023
@marcellamaki marcellamaki added this to the Studio: upcoming patches milestone Jun 22, 2023
@Jaspreet-singh-1032
Copy link
Contributor

Hey @marcellamaki @vkWeb, I was working on this issue. I have truncated the text like this but I think this can cause confusion if two channels names are similar in starting. Let me know if it looks fine or needs to show full names here.

image

@MisRob
Copy link
Member

MisRob commented Jul 4, 2023

Hi @Jaspreet-singh-1032, thank you for picking another issue and asking clarification questions, we appreciate it.

I see two things here.

(1) The decision if we want to use text truncation or allow titles to take more lines. I think it'd be best to hear from @jtamiace or @tomiwaoLE in this regard. However, because right now titles are not readable, it's a pretty high priority and I think it'd be valuable to have it fixed in any of the suggested ways rather sooner than later and we can improve even more later if needed.

This takes me to (2), if you'd like to continue using text truncation to solve this, we need to communicate truncation to users by using the ellipsis (...) rather than cutting a title off without any indication of truncation happening. We already have a component in our codebase for truncating text which is used in similar situations, so it'd be best to use it. The component is TextTruncatorCss and you can search the codebase to see how it's used. Note that you might also come across another similar component, TextTruncator. Please don't use that one as we want to remove it completely in favor of TextTruncatorCss (learningequality/kolibri#8532).

@MisRob
Copy link
Member

MisRob commented Jul 4, 2023

@Jaspreet-singh-1032 I'm assigning both of us but won't work on it myself, it's just for me to keep track of what issues are taken or may need some support. Let us know how it's going any time.

@MisRob
Copy link
Member

MisRob commented Jul 4, 2023

@Jaspreet-singh-1032 I made a mistake, apologies - didn't notice that this is Studio, not Kolibri! So unfortunately we don't have TextTruncatorCss here so you'd need to implement text truncation without that if you go in that direction. You can still refer to Kolibri's TextTruncatorCss for reference if that'd be helpful.

@Jaspreet-singh-1032
Copy link
Contributor

I got it, thanks!

@pcenov
Copy link
Member

pcenov commented Sep 18, 2023

I've filed the following issue for some problems I noticed with the current implementation: #4286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P1 - important Priority: High impact on UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants