-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KTextTruncator component #450
Comments
See developers documentation
|
This is already reserved for contribution for https://github.com/muditchoudhary |
@MisRob Okay I understand the issue. Could you please assign it to me? |
Hi @muditchoudhary, great, it's all yours, thank you |
@muditchoudhary It'd be best if you started working in this repository and as soon as you feel you're ready for
please let me know and I will provide a bit of guidance as it might be tricky for the first time due to some problems with |
Yeah, sure! I have set up the local env. no issue with it.
Sure, I'll let you know if I get into some issue that I cannot resolve. Thanks for telling about the yarn issue. |
@muditchoudhary Okay. I realized we even have an issue where you can find out the description of problems with There's also another pretty simple workaround but let's look at it in case you can't move on with above. |
Hello @MisRob I have copied the
So how do I get this I have tried to find other issues for reference where someone added or updated a component but did not find any. |
Hello @muditchoudhary, we're moving |
|
It's been removed pretty recently so perhaps it was still on your local? |
Ohh yeah! haha I got confused. Thank you! I did not sync my local |
Hello @MisRob I'm almost done with solving the issue, but there is a minor issue when I'm testing the KTextTruncator on Kolibri app. However, that issue does not come when trying in kolibri-design-playground. The ellipsis is added a little forward from the last word.
Tested on: Monitor with 1024x768 size What I think could be the issueWith KTextTruncator there is some right padding but with TextTruncatorCss there is no right padding.
I used |
Hi @muditchoudhary, thanks for staying in touch, this is helpful. I think you can feel free to adjust |
Also, you could see if there are some styles in Kolibri that could be causing this unexpectedly and will need to be removed as we're introducing |
Let me know if this helps. If not, you could open a draft PR with your work in progress and we can have a look at code together |
Closed by #464 |
Product
Kolibri, Studio
Summary
In Kolibri, we have
TextTruncatorCss
component. It would be useful in Studio as well (learningequality/studio#4086, learningequality/studio#4166).Move
TextTruncatorCss
to this repository and rename it toKTextTruncator
. Create a draft documentation page with some basic guidance on using it. Additionally, make sure thatKTextTruncator
works in RTL (right-to-left) languages (you can see learningequality/studio#4288 for how to achieve it)Acceptance criteria
Outside of scope
There is no need to be replacing all
TextTruncatorCss
occurrences in Kolibri byKTextTruncator
in the scope of this issue, only one is needed though to test that everything is okay. Neither it needs to be used in Studio. These could be follow-up tasks.The text was updated successfully, but these errors were encountered: