-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support BNS names in recipient field for sends #1840
Comments
Yes please, big +1 |
+1 (we have the demand!) |
What should the UI look like? Should the preview just show the address and the name? |
Assigning @landitus to design |
Interesting comment here: https://twitter.com/axopoa/status/1519572653278908417
|
From @kyranjamie:
|
homoglyph attacks are not possible because names are limited to a-z, 0-9 and - and _ |
That does indeed limit the scope. We should still use a clear display type, so Oliver.btc is visibly different to OIiver.btc (capital i not L). |
only lower case letters are allowed in BNS names |
+1 for BNS names in recipient fields. |
A blocker is still hirosystems/stacks-blockchain-api#1333 |
does not need to be a blocker, you can use the NFT history endpoint (gamma does this) see https://discord.com/channels/621759717756370964/909867922971820102/1033008587804520459
|
How do we reach all developers to switch from one api endpoint to the other? Seems not an option |
## [3.25.0](v3.24.0...v3.25.0) (2022-11-16) ### Features * send form amount field ([c8621bc](c8621bc)) * support bns recipients, closes [#1840](#1840) ([6dae61e](6dae61e)) ### Bug Fixes * missing address chars, closes [#2860](#2860) ([793f90a](793f90a)) ### Internal * remove unused suspense ([4cab35f](4cab35f))
## [3.26.0](v3.25.0...v3.26.0) (2022-11-24) ### Features * send form amount field ([ab3a10a](ab3a10a)) * send form details ([b6a54bb](b6a54bb)) * support bns recipients, closes [#1840](#1840) ([55bf5ef](55bf5ef)) ### Bug Fixes * amount input in extension ([9b31782](9b31782)) * **balances:** query correct balance, show microblock balance, closes [#2898](#2898) ([da58732](da58732)) * missing address chars, closes [#2860](#2860) ([95bee55](95bee55)) * theme analytics, closes [#2799](#2799) ([8c85177](8c85177)) * typo ([f5f68f3](f5f68f3)) ### Internal * add error handling to form ([fb19774](fb19774)) * base forms for all currencies ([3eec893](3eec893)) * be explicit about address, allow reuse for non-current account ([153b961](153b961)) * form field error styles ([7ebe8c9](7ebe8c9)) * home page with facade pattern ([c1bbd29](c1bbd29)) * improve errors, add focus state ([0d193af](0d193af)) * init new integration tests ([5de2613](5de2613)) * initial test forms ([601c4a8](601c4a8)) * initial value helper, inline error ([15fe88d](15fe88d)) * react query pattern, form routes ([7860ee9](7860ee9)) * remove coupling of balances types, subBalance ([de94f2c](de94f2c)) * remove okcoin ([b34e214](b34e214)) * remove unused suspense ([8369e32](8369e32)) * rename existing tests as legacy ([7b97265](7b97265)) * rename original balance queries with stx naming ([1770e3d](1770e3d)) * semantic form elements ([6f9b123](6f9b123)) * tightens rules against orphan files ([950569a](950569a)) * use factory fn ([b43159a](b43159a)) * validation schemas ([3cd15c5](3cd15c5))
Currently, bns names are not accepted as recipients
Expected behaviour
Allow to enter a bns name in preview and show the resolved address + bns name in final screen
The text was updated successfully, but these errors were encountered: