feat: bns support and registration for connect #1103
Conversation
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/blockstack/stacks-wallet-web/Ft9e3uvQhbrFgAK71fdaaKdwfprr [Deployment for c9a9a89 failed] |
markmhendrickson
added this to 💻 In development | WIP limit: 5
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
|
@hstove Should we take this out of draft mode and move into QA? And do we want to modify the testnet demo app to provide two auth options / buttons: one uses the |
|
I was able to register a username with the Testnet Demo app here: https://stacks-node-api.testnet.stacks.co/v1/names/awegawegawegawegawe.test-registrar.id |
|
@hstove Would it be easy enough to sneak in a "Skip" option on the username screen here? @wilsonbright just requested it given their recent experience with improved conversion without required username registration. If not, we can break it out into its own issue and track there. |
| }; | ||
| }); | ||
| if (apiKey) { | ||
| headers.set('Authorization', `bearer ${apiKey}`); |
There was a problem hiding this comment.
| headers.set('Authorization', `bearer ${apiKey}`); | |
| headers.set('Authorization', `Bearer ${apiKey}`); |
Isn't this typically capitalised?
There was a problem hiding this comment.
Typically, yeah. But the registrar expects lowercase 🤷🏼 .
markmhendrickson
moved this from 💻 In development | WIP limit: 5
to In Review
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
markmhendrickson
moved this from In Review
to 💻 In development | WIP limit: 5
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
|
Registration worked for me:
|
|
@kyranjamie and/or @aulneau can you code review this soon? We should release as soon as possible. @hstove is there any other change necessary, or will we be good to deploy once code review is complete? |
andresgalante
removed this from 🚀 Done Done
in 👟 UserX Kanban [🚨 DEPRECATED in favor of https://github.com/orgs/hirosystems/projects/9/views/1]
Fixes #736, fixes #956, fixes #946
This PR does the following:
Currently only a testnet subdomain registrar is configured. This upgrade must go with hirosystems/stacks.js#984 in order for apps to properly handle the upgrade.