-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: match authResponse username with 2.0 bns lookup #984
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/blockstack/stacks-js/FKzXe7eB3DRUNsgYPzoH6UVcakMC |
@hstove should someone review these code changes now? |
40c27f2
to
602ed83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! left one small style comment
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
==========================================
+ Coverage 60.69% 60.79% +0.09%
==========================================
Files 101 101
Lines 7585 7596 +11
Branches 1412 1414 +2
==========================================
+ Hits 4604 4618 +14
+ Misses 2976 2973 -3
Partials 5 5
Continue to review full report at Codecov.
|
I this ready to merge? |
Yes, ready for merge + release, cc @reedrosenbluth |
Fixes #953
This is the start of the work that will allow apps to handle an
authResponse
properly with 2.0 BNS.After authentication,
@stacks/auth
callsverifyAuthResponse
. This function runs a few checks, and also runs a check to ensure that the auth response is signed by the owner of the username provided in the payload.Right now, you need to use a specific
AppConfig
to have a customcoreNodeUrl
. When provided, it uses a different BNS lookup URL. For testing, I'm using our testnet registrar.