Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/6.11.1 #4416

Merged
merged 38 commits into from
Oct 24, 2023
Merged

Release/6.11.1 #4416

merged 38 commits into from
Oct 24, 2023

Conversation

kyranjamie and others added 30 commits October 13, 2023 17:06
@pete-watters
Copy link
Contributor Author

pete-watters commented Oct 24, 2023

I named it 6.11.1 but I'm not sure if that will be the version increment.

I think we should come up with a system to name the releases the same as the tag and version increment. I used GitFlow CLI for this in the past: https://github.com/nvie/gitflow

@kyranjamie
Copy link
Collaborator

I think we should come up with a system to name the releases the same as the tag and version increment. I used GitFlow CLI for this in the past: https://github.com/nvie/gitflow

Re your point, this is a limitation of semantic-release. The idea is you don't need to know the version, but it's limiting imo. There's an issue asking for a feature that allows you to know ahead of time what version it'll use, so we could do just this.

@kyranjamie
Copy link
Collaborator

I hope the merge back works better this time 🙏🏼

@pete-watters pete-watters merged commit c36316a into main Oct 24, 2023
103 checks passed
@pete-watters pete-watters deleted the release/6.11.1 branch October 24, 2023 14:17
@pete-watters
Copy link
Contributor Author

I think we should come up with a system to name the releases the same as the tag and version increment. I used GitFlow CLI for this in the past: https://github.com/nvie/gitflow

Re your point, this is a limitation of semantic-release. The idea is you don't need to know the version, but it's limiting imo. There's an issue asking for a feature that allows you to know ahead of time what version it'll use, so we could do just this.

Thanks 👍 I'll take a look and see if I can use dry-run or else a plugin to do this. There is a fork we could potentially use also https://github.com/semantic-release-plus/semantic-release-plus

I take it that semantic-release gives us some benefits and we want to keep using it. It's used by nx-release also which I will test run for the mono repo - https://youtu.be/NQHk7HhP1Uo?feature=shared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants