Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[class] Prevent lebab from crashing when using anonymous function declaration on default export #289

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

uniibu
Copy link
Contributor

@uniibu uniibu commented Apr 5, 2019

Fixes a bug on Lebab where in it throws a SyntaxError when class transform is enabled and the user is using anonymous function declaration on default export.

example:

export default function() {}
  • will throw SyntaxError Cannot read property 'name' of null when class transform is enabled

Signed-off-by: Uni Sayo <unibtc@gmail.com>
@codecov-io
Copy link

codecov-io commented Apr 5, 2019

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          83       83           
  Lines        1145     1145           
=======================================
  Hits         1140     1140           
  Misses          5        5
Impacted Files Coverage Δ
src/transform/class/matchFunctionDeclaration.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35f94e1...fef54d9. Read the comment docs.

@nene nene merged commit 7b1d94d into lebab:master Apr 5, 2019
@nene
Copy link
Collaborator

nene commented Apr 5, 2019

Thanks!

@nene
Copy link
Collaborator

nene commented Apr 5, 2019

Published as 3.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants