Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the existing parser from
espree
to@babel/parser
.There is only 1 failed test:
escope
does not recognizeClassMethod
frombabel
. I'm not sure how to fix it. This must be done onescope
side.I have verified that
acorn
andespree
will trigger issue #352 , all other parsers are ok. Butesprima
is kind of dead.Typescript
will run into theescope
issue too. That's why I choose babel.I started to want to patch recast by myself to fix the original issue. But maybe this PR is complete enough that you will have an interest in it. If you think this is not the direction to go, can close. 🙏