Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase import performance (lru_cache) and add pytest-benchmark #279

Merged
merged 10 commits into from
Aug 3, 2023
Merged

Increase import performance (lru_cache) and add pytest-benchmark #279

merged 10 commits into from
Aug 3, 2023

Conversation

lebrice
Copy link
Owner

@lebrice lebrice commented Aug 3, 2023 •
edited

  • Fixes Make simple-parsing faster #278
  • uses lru_cacheed versions of inspect.getdoc and inspect.getsource as well as docstring_parser.parse.
  • Makes the numpy import lazy
  • Adds a pytest-benchmark test dependency
  • Adds a test/test_performance.py file with some simple performance tests

@lebrice
Add pytest-benchmark test dependency
52a0aae 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Add performance files for before the changes
c4d1933 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Use cached versions of inspect.getdoc/getsource
15badca 
Fixes #278

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Make numpy import lazy
3e2ae44 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice changed the title Increase import performance and parsing speed (add lru_cache) Increase import performance (lru_cache) and add pytest-benchmark Aug 3, 2023
@lebrice
Simplify the benchmark code a bit
1897324 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Remove .benchmarks file from git history
ac311dd 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Playing around with GitHub actions for benchmark
9d309fa 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice force-pushed the lebrice/increase_performance branch from 430d966 to 9d309fa Compare August 3, 2023 18:02
@lebrice
Remove upload workflow, add benchmark
4f325b4 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Tweak benchmark.yml and build.yml
3b3cc0e 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Only run workflow on push to master
8338680 
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice lebrice merged commit b3d12de into master Aug 3, 2023
10 checks passed
@lebrice lebrice deleted the lebrice/increase_performance branch August 3, 2023 19:13
@lebrice lebrice mentioned this pull request Aug 8, 2023
Closed
@anivegesana anivegesana mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make simple-parsing faster
1 participant
@lebrice