added support for Kimax U-25AWF #826

danielkucera · 2017-02-13T22:18:45Z

rewrite from https://forum.openwrt.org/viewtopic.php?pid=305643

pepe2k · 2017-02-14T09:23:20Z

Please, fix your commit based on the information about submitting patches: here and here. In current shape it cannot be accepted.

blogic · 2017-02-14T11:09:14Z

target/linux/ramips/base-files/etc/board.d/01_leds

+u25awf)
+        set_wifi_led "u25awf:red:wifi"
+        ucidef_set_led_netdev "eth" "eth" "u25awf:green:lan" "eth0"
+        ;;
 rp-n53)


wrong alphabetical ordering

blogic · 2017-02-14T11:09:29Z

target/linux/ramips/base-files/etc/board.d/02_network

@@ -134,6 +134,7 @@ ramips_setup_interfaces()
 	atp-52b|\
 	awm002-evb|\
 	awm003-evb|\
+        u25awf|\
 	c20i|\


wrong ordering and bad indenting

blogic · 2017-02-14T11:09:34Z

target/linux/ramips/base-files/etc/diag.sh

@@ -171,6 +171,9 @@ get_status_led() {
 	nw718)
 		status_led="$board:amber:cpu"
 		;;
+        u25awf)
+                status_led="u25awf:red:wifi"
+                ;;
 	newifi-d1)


wrong ordering and bad indenting

blogic · 2017-02-14T11:09:40Z

target/linux/ramips/base-files/lib/ramips.sh

@@ -511,6 +511,9 @@ ramips_board_detect() {
 	*"WF-2881")
 		name="wf-2881"
 		;;
+        *"U-25AWF")
+                name="u25awf"
+                ;;
 	*"WHR-1166D")


wrong ordering and bad indenting

blogic · 2017-02-14T11:09:46Z

target/linux/ramips/base-files/lib/upgrade/platform.sh

@@ -151,6 +151,7 @@ platform_check_image() {
 	witi|\
 	wizfi630a|\
 	wl-330n|\
+        u25awf |\
 	wl-330n3g|\


wrong ordering and bad indenting

blogic · 2017-02-14T11:09:57Z

target/linux/ramips/dts/U25AWF.dts

+
+       palmbus@10000000 {
+                               gpio0: gpio@600 {
+                        status = "okay";


bad indenting

blogic · 2017-02-14T11:10:02Z

target/linux/ramips/dts/U25AWF.dts

+                };
+
+                               gpio1: gpio@638 {
+                        status = "okay";


bad indenting

blogic · 2017-02-14T11:10:25Z

target/linux/ramips/dts/U25AWF.dts

+                gpio3: gpio@688 {
+                        status = "okay";
+                };
+


the whole file is badly indented. please use tabs and not spaces

danielkucera · 2017-02-14T11:19:05Z

Ok, I'll submit a new one.

danielkucera · 2017-02-18T14:47:17Z

I just commit-ed a new version.

bobafetthotmail · 2017-02-18T19:40:17Z

Looks good, but it lacks

Signed-off-by: myname mysurname <myemail@email.com>

Please add it.

danielkucera · 2017-02-19T08:48:30Z

Oh, I forgot... What about now?

mkresin

Please use git commit --amend to add changes to your commit. Use git push --force to overwrite your github repository/branch. The PR will afterwards update automatically.

mkresin · 2017-02-19T09:53:33Z

target/linux/ramips/dts/U25AWF.dts

+		poll-interval=<20>;
+		reset{
+			label="reset";
+			gpios=<&gpio231>;


That doesn't work. there are a few whitespaces missing in <&gpio231>;. Should rather be <&gpio2 3 1>; or similar. Seam to apply to all gpios properties.

mkresin · 2017-02-19T09:58:07Z

target/linux/ramips/dts/U25AWF.dts

@@ -0,0 +1,114 @@
+/dts-v1/;
+
+/include/"mt7620n.dtsi"


#include "mt7620n.dtsi"

mkresin · 2017-02-19T09:59:38Z

target/linux/ramips/dts/U25AWF.dts

@@ -0,0 +1,114 @@
+/dts-v1/;
+
+/include/"mt7620n.dtsi"


Please include <dt-bindings/gpio/gpio.h> and <dt-bindings/input/input.h> here as well.

Use the GPIO_ACTIVE_LOW and GPIO_ACTIVE_HIGH macros afterwards in stead of 1 and 0 in the gpio parameters.

Use the Key macros instead of the hex values in linux,code.

Check the recent ramips board additions for examples.

mkresin · 2017-02-19T10:01:07Z

target/linux/ramips/dts/U25AWF.dts

+			m25p80@0{
+				#address-cells=<1>;
+				#size-cells=<1>;
+				compatible="mx25l12805d";


compatible = "jedec,spi-nor";

mkresin · 2017-02-19T10:01:17Z

target/linux/ramips/dts/U25AWF.dts

+				#address-cells=<1>;
+				#size-cells=<1>;
+				compatible="mx25l12805d";
+				reg=<00>;


mkresin · 2017-02-19T10:01:52Z

target/linux/ramips/dts/U25AWF.dts

+				#size-cells=<1>;
+				compatible="mx25l12805d";
+				reg=<00>;
+				linux,modalias="m25p80","m25p128";


Drop this line. It was only required for kernels < 4.4

mkresin · 2017-02-19T10:03:55Z

target/linux/ramips/dts/U25AWF.dts

+
+	palmbus@10000000{
+		gpio0:gpio@600{
+			status="okay";


please use whitespaces around the equal sign. Without the equal signs it is kinda hard to read.

The same applies to all {. They should have a leading whitespace.

The same applies to all :. They should have a trainling whitespace.

Have a look how it is done in the other dts files.

You can drop the whole gpio0 node. it is already enabled in mt7620n.dtsi.

mkresin · 2017-02-19T10:06:29Z

target/linux/ramips/dts/U25AWF.dts

+			status="okay";
+		};
+
+		gpio1:gpio@638{


drop this node. as far as i can see, gpio1 isn't used in the dts.

mkresin · 2017-02-19T10:11:24Z

Please provide a bootlog after you done all requested changes. Some of the spotted mistakes make it quite obvious that it isn't runtime tested and maybe even not compile tested.

danielkucera · 2017-02-21T18:23:45Z

guys, I don't have serial access to my device (it's kinda hard to solder) so I'm not going to experiment with these changes.

Mynzer · 2017-10-05T22:21:14Z

Hi, good day.

I'm interested in that this device gets full lede support in the future, currently my device is running a compiled lede 17.01.2 version with @danielkucera patch for openwrt

https://github.com/openwrt/openwrt/pull/380/files

I'm agree with @danielkucera that is very hard to solder serial access to this device, so in order to avoid brick my device, I've compiled a lede version with unlocked u-boot partition and I've change stock u-boot to breed bootloader for easy recovery this device.

in case that @danielkucera is interested, y could test any firmware that he compile and provide boot logs, or i could provide the steps and files that i use to change the stock u-boot so that @danielkucera could make any test in his device.

Greetings and thanks for all the hard work

danielkucera · 2017-10-06T05:33:20Z

Hi Mynzer,

I already have my device in "production" so I'm not able to develop on in. But I can try to apply requested changes if you are willing to test them.

danielkucera · 2017-10-06T10:06:50Z

Rebased against current master, new PR: #1402

danielkucera · 2017-10-06T10:40:13Z

@Mynzer can you please test branch u25awf https://github.com/danielkucera/source/tree/u25awf and provide bootlog?

Mynzer · 2017-10-06T18:35:36Z

Ok, when i try to compile from https://github.com/danielkucera/source/tree/u25awf branch, i've got the following error
CompileError.txt

danielkucera · 2017-10-06T18:41:22Z

try to pull it now

danielkucera · 2017-10-06T19:32:53Z

@Mynzer there were more errors, please try current version and respond to issue #1402 from now on.

Mynzer · 2017-10-06T19:36:53Z

Ok, I'm in the middle of a previous compilation, I'm going to cancel all, pull again from your branch and report on #1402

danielkucera · 2017-10-06T19:41:48Z

you don't need to make clean when testing updated version. just git pull and make

Mynzer · 2017-10-06T22:10:01Z

Ok, I see this message to late, next updates will use git pull, by the way, I'm ready to provide bootlog when you apply the new change request

danielkucera · 2017-10-06T22:17:02Z

So what's your status now? Dňa 7. 10. 2017 12:10 dopoludnia používateľ "Mynzer" < notifications@github.com> napísal:

…

Ok, I see this message to late, next updates will use git pull, by the way, I'm ready to provide bootlog when you apply the new change request — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#826 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABp2cAmZJnAksWilGs7upQ4K6foRi9Ntks5spqU_gaJpZM4L_y_b> .

blogic requested changes Feb 14, 2017

View reviewed changes

danielkucera force-pushed the master branch 2 times, most recently from d3a8208 to 7e76d57 Compare February 18, 2017 14:45

danielkucera force-pushed the master branch from 7e76d57 to 1072b68 Compare February 19, 2017 08:47

mkresin requested changes Feb 19, 2017

View reviewed changes

danielkucera closed this Feb 21, 2017

danielkucera reopened this Oct 6, 2017

danielkucera closed this Oct 6, 2017

danielkucera force-pushed the master branch from 1072b68 to 834c93e Compare October 6, 2017 10:02

mkresin mentioned this pull request Oct 6, 2017

ramips: add support for Kimax U-25AWF 2.5" SATA WIFI HDD Enclosure #1402

Closed

		@@ -0,0 +1,114 @@
		/dts-v1/;

		/include/"mt7620n.dtsi"

		@@ -0,0 +1,114 @@
		/dts-v1/;

		/include/"mt7620n.dtsi"

added support for Kimax U-25AWF #826

added support for Kimax U-25AWF #826

Conversation

danielkucera commented Feb 13, 2017

pepe2k commented Feb 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielkucera commented Feb 14, 2017

danielkucera commented Feb 18, 2017

bobafetthotmail commented Feb 18, 2017 • edited Loading

danielkucera commented Feb 19, 2017

mkresin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkresin commented Feb 19, 2017

danielkucera commented Feb 21, 2017

Mynzer commented Oct 5, 2017

danielkucera commented Oct 6, 2017

danielkucera commented Oct 6, 2017

danielkucera commented Oct 6, 2017

Mynzer commented Oct 6, 2017

danielkucera commented Oct 6, 2017

danielkucera commented Oct 6, 2017

Mynzer commented Oct 6, 2017

danielkucera commented Oct 6, 2017

Mynzer commented Oct 6, 2017

danielkucera commented Oct 6, 2017 via email

bobafetthotmail commented Feb 18, 2017 •

edited

Loading