-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for Kimax U-25AWF #826
Conversation
u25awf) | ||
set_wifi_led "u25awf:red:wifi" | ||
ucidef_set_led_netdev "eth" "eth" "u25awf:green:lan" "eth0" | ||
;; | ||
rp-n53) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong alphabetical ordering
@@ -134,6 +134,7 @@ ramips_setup_interfaces() | |||
atp-52b|\ | |||
awm002-evb|\ | |||
awm003-evb|\ | |||
u25awf|\ | |||
c20i|\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong ordering and bad indenting
@@ -171,6 +171,9 @@ get_status_led() { | |||
nw718) | |||
status_led="$board:amber:cpu" | |||
;; | |||
u25awf) | |||
status_led="u25awf:red:wifi" | |||
;; | |||
newifi-d1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong ordering and bad indenting
@@ -511,6 +511,9 @@ ramips_board_detect() { | |||
*"WF-2881") | |||
name="wf-2881" | |||
;; | |||
*"U-25AWF") | |||
name="u25awf" | |||
;; | |||
*"WHR-1166D") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong ordering and bad indenting
@@ -151,6 +151,7 @@ platform_check_image() { | |||
witi|\ | |||
wizfi630a|\ | |||
wl-330n|\ | |||
u25awf |\ | |||
wl-330n3g|\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong ordering and bad indenting
target/linux/ramips/dts/U25AWF.dts
Outdated
|
||
palmbus@10000000 { | ||
gpio0: gpio@600 { | ||
status = "okay"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad indenting
target/linux/ramips/dts/U25AWF.dts
Outdated
}; | ||
|
||
gpio1: gpio@638 { | ||
status = "okay"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad indenting
target/linux/ramips/dts/U25AWF.dts
Outdated
gpio3: gpio@688 { | ||
status = "okay"; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole file is badly indented. please use tabs and not spaces
Ok, I'll submit a new one. |
d3a8208
to
7e76d57
Compare
I just commit-ed a new version. |
Looks good, but it lacks Signed-off-by: myname mysurname <myemail@email.com> Please add it. |
Oh, I forgot... What about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use git commit --amend
to add changes to your commit. Use git push --force
to overwrite your github repository/branch. The PR will afterwards update automatically.
target/linux/ramips/dts/U25AWF.dts
Outdated
poll-interval=<20>; | ||
reset{ | ||
label="reset"; | ||
gpios=<&gpio231>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't work. there are a few whitespaces missing in <&gpio231>;
. Should rather be <&gpio2 3 1>;
or similar. Seam to apply to all gpios properties.
target/linux/ramips/dts/U25AWF.dts
Outdated
@@ -0,0 +1,114 @@ | |||
/dts-v1/; | |||
|
|||
/include/"mt7620n.dtsi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "mt7620n.dtsi"
target/linux/ramips/dts/U25AWF.dts
Outdated
@@ -0,0 +1,114 @@ | |||
/dts-v1/; | |||
|
|||
/include/"mt7620n.dtsi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include <dt-bindings/gpio/gpio.h> and <dt-bindings/input/input.h> here as well.
Use the GPIO_ACTIVE_LOW and GPIO_ACTIVE_HIGH macros afterwards in stead of 1 and 0 in the gpio parameters.
Use the Key macros instead of the hex values in linux,code.
Check the recent ramips board additions for examples.
target/linux/ramips/dts/U25AWF.dts
Outdated
m25p80@0{ | ||
#address-cells=<1>; | ||
#size-cells=<1>; | ||
compatible="mx25l12805d"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compatible = "jedec,spi-nor";
target/linux/ramips/dts/U25AWF.dts
Outdated
#address-cells=<1>; | ||
#size-cells=<1>; | ||
compatible="mx25l12805d"; | ||
reg=<00>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reg=<0>;
target/linux/ramips/dts/U25AWF.dts
Outdated
#size-cells=<1>; | ||
compatible="mx25l12805d"; | ||
reg=<00>; | ||
linux,modalias="m25p80","m25p128"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this line. It was only required for kernels < 4.4
target/linux/ramips/dts/U25AWF.dts
Outdated
|
||
palmbus@10000000{ | ||
gpio0:gpio@600{ | ||
status="okay"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use whitespaces around the equal sign. Without the equal signs it is kinda hard to read.
The same applies to all {
. They should have a leading whitespace.
The same applies to all :
. They should have a trainling whitespace.
Have a look how it is done in the other dts files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop the whole gpio0 node. it is already enabled in mt7620n.dtsi.
target/linux/ramips/dts/U25AWF.dts
Outdated
status="okay"; | ||
}; | ||
|
||
gpio1:gpio@638{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop this node. as far as i can see, gpio1 isn't used in the dts.
Please provide a bootlog after you done all requested changes. Some of the spotted mistakes make it quite obvious that it isn't runtime tested and maybe even not compile tested. |
guys, I don't have serial access to my device (it's kinda hard to solder) so I'm not going to experiment with these changes. |
Hi, good day. I'm interested in that this device gets full lede support in the future, currently my device is running a compiled lede 17.01.2 version with @danielkucera patch for openwrt https://github.com/openwrt/openwrt/pull/380/files I'm agree with @danielkucera that is very hard to solder serial access to this device, so in order to avoid brick my device, I've compiled a lede version with unlocked u-boot partition and I've change stock u-boot to breed bootloader for easy recovery this device. in case that @danielkucera is interested, y could test any firmware that he compile and provide boot logs, or i could provide the steps and files that i use to change the stock u-boot so that @danielkucera could make any test in his device. Greetings and thanks for all the hard work |
Hi Mynzer, I already have my device in "production" so I'm not able to develop on in. But I can try to apply requested changes if you are willing to test them. |
Rebased against current master, new PR: #1402 |
@Mynzer can you please test branch u25awf https://github.com/danielkucera/source/tree/u25awf and provide bootlog? |
Ok, when i try to compile from https://github.com/danielkucera/source/tree/u25awf branch, i've got the following error |
try to pull it now |
Ok, I'm in the middle of a previous compilation, I'm going to cancel all, pull again from your branch and report on #1402 |
you don't need to make clean when testing updated version. just |
Ok, I see this message to late, next updates will use |
So what's your status now?
Dňa 7. 10. 2017 12:10 dopoludnia používateľ "Mynzer" <
notifications@github.com> napísal:
… Ok, I see this message to late, next updates will use git pull, by the
way, I'm ready to provide bootlog when you apply the new change request
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#826 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABp2cAmZJnAksWilGs7upQ4K6foRi9Ntks5spqU_gaJpZM4L_y_b>
.
|
rewrite from https://forum.openwrt.org/viewtopic.php?pid=305643