Adding persistent option to has_settings #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the great work with this gem. It is very useful for us.
In my project, I need to define some settings in a Concern and then another set of settings in the model. Currently, the configuration class resets the default_settings in every has_settings call.
To allow settings additions I added a persistent option. I realize the code could be better. However, initially, I would like you to analyze if this type of solution is acceptable.
Thanks again.