Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding persistent option to has_settings #99

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Adding persistent option to has_settings #99

merged 1 commit into from
Aug 22, 2019

Conversation

nicolaiespresso
Copy link
Contributor

Hello,

Thanks for the great work with this gem. It is very useful for us.

In my project, I need to define some settings in a Concern and then another set of settings in the model. Currently, the configuration class resets the default_settings in every has_settings call.
To allow settings additions I added a persistent option. I realize the code could be better. However, initially, I would like you to analyze if this type of solution is acceptable.

Thanks again.

@coveralls
Copy link

coveralls commented Aug 20, 2019

Coverage Status

Coverage increased (+0.09%) to 96.212% when pulling 65f2768 on nicolaiespresso:master into 0edc87f on ledermann:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 96.97% when pulling 137ad36 on nicolaiespresso:master into 8888fa1 on ledermann:master.

@ledermann
Copy link
Owner

Looks good to me, thanks. Just one thing: Please remove the version number change.

@nicolaiespresso
Copy link
Contributor Author

Ok, just reverted the version file.

@ledermann ledermann merged commit b6e5ce9 into ledermann:master Aug 22, 2019
@ledermann
Copy link
Owner

Merged. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants