Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-schedule-upcoming doesn't use ledger-use-iso-dates #36

Closed
jmrgithub opened this issue Jun 4, 2017 · 3 comments
Closed

ledger-schedule-upcoming doesn't use ledger-use-iso-dates #36

jmrgithub opened this issue Jun 4, 2017 · 3 comments

Comments

@jmrgithub
Copy link

When I use scheduling, dates always come out in YYYY/MM/DD format for me, even though I have ledger-use-iso-dates set to t.
@purcell
Copy link
Member

purcell commented Jun 4, 2017

This is because there's a ledger-default-date-format setting and ledger-use-iso-dates, but not all the code checks the latter before using the former. I suggest that we should remove ledger-use-iso-dates in favour of simply advising people to use set ledger-default-date-format to "%Y-%m-%d". ledger-use-iso-dates seems to be a bit of a hacky addition.

@jmrgithub
Copy link
Author

Thank you - setting ledger-default-date-format as you suggested fixed my problem!

@purcell purcell closed this as completed in 782014a Jun 5, 2017
@purcell
Copy link
Member

purcell commented Jun 5, 2017

Okay, I just pushed a bunch of related changes which overhaul how dates are read and formatted. The suggested incantation is now to (setq ledger-default-date-format ledger-iso-date-format), and this should ensure that dates are read and formatted consistently everywhere.

As part of this, I've switched ledger-read-date to use org-read-date under the hood, but preferring past dates rather than future dates (as would be the default). So "1" would (today) mean "June 1st", "15 Jan 7" would mean 15th Jan 2007 etc. There was some inconsistently-applied code to change the default month/year for date entry, which I've removed because I think the org shorthand and interface is a net win for date entry speed.

Let me know how you get on.

delexi added a commit to delexi/spacemacs that referenced this issue Mar 24, 2018
@delexi
Remove key-bindings pointing to removed commands
3e14342 
The ledger-mode maintainers removed ledger-set-month and ledger-set-year to fix
ledger/ledger-mode#36. This was done in commit
782014ae.
delexi added a commit to delexi/spacemacs that referenced this issue Mar 24, 2018
@delexi
Remove key-bindings pointing to removed commands
7073495 
The ledger-mode maintainers removed ledger-set-month and ledger-set-year to fix
ledger/ledger-mode#36. This was done in commit
782014ae.

The finance layer still had key-bindings pointing to these functions, that are
no longer defined, leading to errors when executing one of those bindings. This
simply removes the bindings to avoid confusion.
@delexi delexi mentioned this issue Mar 24, 2018
Closed
delexi added a commit to delexi/spacemacs that referenced this issue Mar 24, 2018
@delexi
Remove key-bindings pointing to removed commands
9133f65 
The ledger-mode maintainers removed ledger-set-month and ledger-set-year to fix
ledger/ledger-mode#36. This was done in commit
782014ae.

The finance layer still had key-bindings pointing to these functions, that are
no longer defined, leading to errors when executing one of those bindings. This
simply removes the bindings to avoid confusion.
sdwolfz pushed a commit to syl20bnr/spacemacs that referenced this issue May 14, 2018
@delexi @sdwolfz
Remove key-bindings pointing to removed commands
5b70ac5 
The ledger-mode maintainers removed ledger-set-month and ledger-set-year to fix
ledger/ledger-mode#36. This was done in commit
782014ae.

The finance layer still had key-bindings pointing to these functions, that are
no longer defined, leading to errors when executing one of those bindings. This
simply removes the bindings to avoid confusion.
buckarooch pushed a commit to profilech/.emacs.d that referenced this issue May 19, 2018
@delexi @buckarooch
Remove key-bindings pointing to removed commands
ba30f08 
The ledger-mode maintainers removed ledger-set-month and ledger-set-year to fix
ledger/ledger-mode#36. This was done in commit
782014ae.

The finance layer still had key-bindings pointing to these functions, that are
no longer defined, leading to errors when executing one of those bindings. This
simply removes the bindings to avoid confusion.
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this issue Oct 29, 2018
@delexi
Remove key-bindings pointing to removed commands
acbfcee 
The ledger-mode maintainers removed ledger-set-month and ledger-set-year to fix
ledger/ledger-mode#36. This was done in commit
782014ae.

The finance layer still had key-bindings pointing to these functions, that are
no longer defined, leading to errors when executing one of those bindings. This
simply removes the bindings to avoid confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@purcell @jmrgithub