Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use https scheme for links in CONTRIBUTING.md #2285

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Use https scheme for links in CONTRIBUTING.md #2285

merged 1 commit into from
Jul 10, 2024

Conversation

afh
Copy link
Member

@afh afh commented Aug 29, 2023

[ci skip]

@afh afh added the documentation Related to the documentation label Aug 29, 2023
@afh afh self-assigned this Aug 29, 2023
mankalas
mankalas approved these changes Nov 16, 2023
View reviewed changes
Copy link

@mankalas mankalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested all changed links and they're all valid.

@afh afh requested a review from tbm December 6, 2023 11:24
@afh
Copy link
Member Author

afh commented Dec 6, 2023

Kindly requesting review from @tbm.

@afh afh added the easy Trivial changes easy to review label Dec 7, 2023
jwiegley
jwiegley approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@jwiegley jwiegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

@jwiegley jwiegley merged commit 0c323a5 into ledger:master Jul 10, 2024
@afh afh deleted the contributing-https-links branch July 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiegley jwiegley jwiegley approved these changes

@mankalas mankalas mankalas approved these changes

@tbm tbm Awaiting requested review from tbm

Assignees

@afh afh

Labels
documentation Related to the documentation easy Trivial changes easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afh @jwiegley @mankalas