Merge pull request #7570 from ehuelsmann/test/1.9/pherkin-upgrade

1.9/pherkin upgrade
ledgersmb · Aug 12, 2023 · 0a9ba2c · 0a9ba2c
2 parents a444b10 + a702329
commit 0a9ba2c
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -137,7 +137,7 @@ else
 	yath test --no-color --retry=2 \
             --pgtap-dbname=lsmb_test --pgtap-username=postgres \
             --pgtap-psql=.circleci/psql-wrap \
-            --Feature-tags=~@wip \
+            --Feature-tags='not @wip' \
             $(TESTS)
 endif
 

diff --git a/cpanfile b/cpanfile
@@ -173,12 +173,12 @@ on 'develop' => sub {
     requires 'Perl::Critic';
     requires 'Perl::Critic::Moose';
     requires 'Perl::Critic::Policy::Modules::RequireExplicitInclusion';
-    requires 'Pherkin::Extension::Weasel', '0.15';
+    requires 'Pherkin::Extension::Weasel', '0.17';
     requires 'Plack::Middleware::Pod'; # YLA - Generate browseable documentation
     requires 'Pod::ProjectDocs';
     requires 'Selenium::Remote::Driver';
     requires 'TAP::Parser::SourceHandler::pgTAP', '3.33';
-    requires 'Test::BDD::Cucumber', '0.79';
+    requires 'Test::BDD::Cucumber', '0.86';
     if ($ENV{CI}) {
         # Required to suppress a variable re-definition
         requires 'Test::Dependencies', '0.30';

diff --git a/xt/65-browser.t b/xt/65-browser.t
@@ -4,7 +4,7 @@ use strict;
 use warnings;
 
 use Test::More;
-use YAML::Syck;
+use YAML qw(LoadFile);
 
 # If we choose to depend on environment variables,
 # uncomment the next lines and initialize reqenv with their names

diff --git a/xt/lib/Pherkin/Extension/LedgerSMB.pm b/xt/lib/Pherkin/Extension/LedgerSMB.pm
@@ -157,7 +157,7 @@ sub pre_scenario {
     $stash->{"the admin password"} = $self->admin_user_password;
 
     if ($self->last_feature_stash->{"the company"}
-        && any { $_ eq 'one-db' } @{$scenario->tags}) {
+        && any { $_ eq '@one-db' } @{$scenario->tags}) {
         $stash->{"the company"} = $self->last_feature_stash->{"the company"};
     }
 }

diff --git a/xt/lib/Pherkin/Extension/PageObject.pm b/xt/lib/Pherkin/Extension/PageObject.pm
@@ -81,7 +81,7 @@ sub post_step {
     my $scenario = $step_context->scenario;
 
     if ((lc($step_context->verb) eq 'when')
-        and (any { $_ eq 'weasel' } @{$scenario->tags})) {
+        and (any { $_ eq '@weasel' } @{$scenario->tags})) {
         my $s = $step_context->stash->{scenario};
 
         # is there a maindiv element?