Workflow 2.0 (#8138)

* Make LedgerSMB Workflow 2.0 compatible

* List Workflow::Condition dependency

cpanfile

@@ -119,6 +119,7 @@ requires 'Text::Markdown';
 requires 'URI';
 requires 'URI::Escape';
 requires 'Workflow', '1.59';
+requires 'Workflow::Condition', '1.59';
 requires 'Workflow::Context', '1.59';
 requires 'Workflow::Exception', '1.59';
 requires 'Workflow::Factory', '1.59';

lib/LedgerSMB/Workflow/Condition/ACL.pm

@@ -32,7 +32,7 @@ use parent qw( Workflow::Condition );
 use LedgerSMB::Setting;
 
 use Log::Any qw($log);
-use Workflow::Exception qw( configuration_error condition_error );
+use Workflow::Exception qw( configuration_error );
 
 
 =head2 init

lib/LedgerSMB/Workflow/Condition/PeriodClosed.pm

@@ -53,7 +53,6 @@ use parent qw( Workflow::Condition );
 use LedgerSMB::Setting;
 
 use Log::Any qw($log);
-use Workflow::Exception qw( condition_error );
 
 my @PROPS = qw( offset workflow_parameter );
 __PACKAGE__->mk_accessors(@PROPS);
@@ -97,8 +96,7 @@ sub evaluate {
         die $dbh->errstr if $dbh->err;
     }
 
-    condition_error 'Period open' if $opened;
-    return 1;
+    return not $opened;
 }
 
 

lib/LedgerSMB/Workflow/Condition/SeparateDuties.pm

@@ -30,7 +30,6 @@ use parent qw( Workflow::Condition );
 use LedgerSMB::Setting;
 
 use Log::Any qw($log);
-use Workflow::Exception qw( condition_error );
 
 
 =head2 evaluate( $wf )
@@ -47,10 +46,8 @@ sub evaluate {
 
     my $separate_duties = LedgerSMB::Setting->new(dbh => $dbh)->get('separate_duties');
     $log->info("separate duties: $separate_duties");
-    condition_error 'Separation of Duties disabled'
-        if not $separate_duties;
 
-    return 1;
+    return $separate_duties;
 }
 
 

lib/LedgerSMB/Workflow/Loader.pm

@@ -40,6 +40,9 @@ our $VERSION = '0.0.1';
 use File::Find::Rule;
 use File::Spec;
 use Workflow::Factory;
+use Workflow::Condition;
+
+$Workflow::Condition::STRICT_BOOLEANS = 0;
 
 =head1 CLASS METHODS