Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LedgerSMB::Entity::Credit_Account requires 'curr', but database model does not #1116

Closed
ehuelsmann opened this issue Dec 11, 2015 · 1 comment
Closed

LedgerSMB::Entity::Credit_Account requires 'curr', but database model does not #1116

ehuelsmann opened this issue Dec 11, 2015 · 1 comment
Milestone
1.4.29

Comments

@ehuelsmann
Copy link
Member

It's possible to create database input which renders the web app completely unusable.

There are likely more fields like this. Do we really need currencies to be defined???
@ehuelsmann ehuelsmann added this to the 1.4 milestone Dec 11, 2015
@einhverfr einhverfr modified the milestones: 1.4, 1.4.27 Feb 14, 2016
@einhverfr
Copy link
Member

Suggest we update to default currency where missing and add the constraint?

@einhverfr einhverfr modified the milestones: 1.4.27, 1.4.28 Mar 18, 2016
@ehuelsmann ehuelsmann modified the milestones: 1.4.28, 1.4.29 May 3, 2016
ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue May 23, 2016
@ehuelsmann
* Fix ledgersmb#1116 ('curr' required by object, but not DB) by remov…
39a4ee2 
…ing the constraint

Note: I tried to do it the other way around (add the constraint to the DB)
   but that doesn't work out because of the inventory entity being created
   before any currencies have been set.
ehuelsmann added a commit that referenced this issue May 23, 2016
@ehuelsmann
Merge pull request #1589 from ehuelsmann/1.4-issue-1116
1257b0e 
* Fix #1116 ('curr' required by object, but not DB) by removing the c…
ehuelsmann added a commit that referenced this issue May 23, 2016
@ehuelsmann
Merge pull request #1590 from ehuelsmann/master-issue-1116
6cb111f 
* Fix #1116 ('curr' required by object, but not DB) by removing the c…
ylavoie pushed a commit to ylavoie/LedgerSMB that referenced this issue Jun 2, 2016
@ehuelsmann @ylavoie
* Fix ledgersmb#1116 ('curr' required by object, but not DB) by remov…
16d02a0 
…ing the constraint

Note: I tried to do it the other way around (add the constraint to the DB)
   but that doesn't work out because of the inventory entity being created
   before any currencies have been set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.29
Development

No branches or pull requests
2 participants
@einhverfr @ehuelsmann